Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the numbers of iterations in benchmarkshttp/check_is_http_token #15218

Closed
mcollina opened this issue Sep 6, 2017 · 4 comments
Closed
Labels
benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. question Issues that look for answers.

Comments

@mcollina
Copy link
Member

mcollina commented Sep 6, 2017

  • Version: master
  • Platform:
  • Subsystem: benchmarks

Currently benchmark/http/check_is_http_token takes several hours to complete if we try to compare two different Node versions. I think we should lower the number of iterations to simplify benchmarking the whole of http.

Specifically, I propose to revert this commit 39fdf07, or to reduce the number to something in between.
This was part of #6570.

@mscdex @nodejs/benchmarking what do you think?

@mscdex
Copy link
Contributor

mscdex commented Sep 6, 2017

To be honest, what the benchmarks in general could use is either some way to have specific n values for different mixes of inputs (would require some extra logic in each benchmark file) or we just switch to some sort of time-based mechanism for these synchronous benchmarks (would require some coordination with the benchmark runner).

@mscdex mscdex added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. question Issues that look for answers. labels Sep 6, 2017
@bnoordhuis
Copy link
Member

@mcollina Ping. Do you want to follow up?

@mcollina
Copy link
Member Author

I'm open to discuss this, but I do not see any actionable comment so far. What do we want to do?

@BridgeAR
Copy link
Member

This changed recently again in #14002. Closing this therefore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. question Issues that look for answers.
Projects
None yet
Development

No branches or pull requests

4 participants