You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently benchmark/http/check_is_http_token takes several hours to complete if we try to compare two different Node versions. I think we should lower the number of iterations to simplify benchmarking the whole of http.
Specifically, I propose to revert this commit 39fdf07, or to reduce the number to something in between.
This was part of #6570.
To be honest, what the benchmarks in general could use is either some way to have specific n values for different mixes of inputs (would require some extra logic in each benchmark file) or we just switch to some sort of time-based mechanism for these synchronous benchmarks (would require some coordination with the benchmark runner).
mscdex
added
benchmark
Issues and PRs related to the benchmark subsystem.
http
Issues or PRs related to the http subsystem.
question
Issues that look for answers.
labels
Sep 6, 2017
Currently benchmark/http/check_is_http_token takes several hours to complete if we try to compare two different Node versions. I think we should lower the number of iterations to simplify benchmarking the whole of http.
Specifically, I propose to revert this commit 39fdf07, or to reduce the number to something in between.
This was part of #6570.
@mscdex @nodejs/benchmarking what do you think?
The text was updated successfully, but these errors were encountered: