Skip to content

Commit

Permalink
test,benchmark: use tmpdir.fileURL()
Browse files Browse the repository at this point in the history
PR-URL: #49138
Refs: #49040
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
LiviaMedeiros authored and UlisesGascon committed Sep 10, 2023
1 parent e391f4b commit fac56db
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 16 deletions.
4 changes: 1 addition & 3 deletions benchmark/esm/esm-loader-import.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@
// general startup, does not test lazy operations
'use strict';
const fs = require('node:fs');
const path = require('node:path');
const common = require('../common.js');

const tmpdir = require('../../test/common/tmpdir.js');
const { pathToFileURL } = require('node:url');

const benchmarkDirectory = pathToFileURL(path.resolve(tmpdir.path, 'benchmark-import'));
const benchmarkDirectory = tmpdir.fileURL('benchmark-import');

const configs = {
n: [1e3],
Expand Down
5 changes: 1 addition & 4 deletions test/es-module/test-esm-dynamic-import-mutating-fs.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,9 @@ const tmpdir = require('../common/tmpdir');

const assert = require('node:assert');
const fs = require('node:fs/promises');
const { pathToFileURL } = require('node:url');

tmpdir.refresh();
const tmpDir = pathToFileURL(tmpdir.path);

const target = new URL(`./${Math.random()}.mjs`, tmpDir);
const target = tmpdir.fileURL(`${Math.random()}.mjs`);

(async () => {

Expand Down
5 changes: 1 addition & 4 deletions test/es-module/test-esm-dynamic-import-mutating-fs.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,9 @@ import tmpdir from '../common/tmpdir.js';
import assert from 'node:assert';
import fs from 'node:fs/promises';
import { execPath } from 'node:process';
import { pathToFileURL } from 'node:url';

tmpdir.refresh();
const tmpDir = pathToFileURL(tmpdir.path);

const target = new URL(`./${Math.random()}.mjs`, tmpDir);
const target = tmpdir.fileURL(`${Math.random()}.mjs`);

await assert.rejects(import(target), { code: 'ERR_MODULE_NOT_FOUND' });

Expand Down
5 changes: 0 additions & 5 deletions test/node-api/test_policy/test_policy.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ const policyFilepath = tmpdir.resolve('policy');
const depFilepath = require.resolve(`./build/${common.buildType}/binding.node`);
const depURL = pathToFileURL(depFilepath);

const tmpdirURL = pathToFileURL(tmpdir.path);
if (!tmpdirURL.pathname.endsWith('/')) {
tmpdirURL.pathname += '/';
}

const depBody = fs.readFileSync(depURL);
function writePolicy(...resources) {
const manifest = { resources: {} };
Expand Down

0 comments on commit fac56db

Please sign in to comment.