From f44b18f010d3548f8429afd415eee0a034bedbf4 Mon Sep 17 00:00:00 2001 From: Evan Lucas Date: Thu, 2 Jun 2016 06:45:33 -0500 Subject: [PATCH] cluster: deprecate worker.suicide Deprecate worker.suicide in favor of worker.exitedAfterDisconnect. PR-URL: https://github.com/nodejs/node/pull/3747 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Stephen Belanger --- lib/cluster.js | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/cluster.js b/lib/cluster.js index 34f27d0c120efc..228ad0dfe28c06 100644 --- a/lib/cluster.js +++ b/lib/cluster.js @@ -6,6 +6,7 @@ const dgram = require('dgram'); const fork = require('child_process').fork; const net = require('net'); const util = require('util'); +const internalUtil = require('internal/util'); const SCHED_NONE = 1; const SCHED_RR = 2; @@ -30,14 +31,14 @@ function Worker(options) { this.exitedAfterDisconnect = undefined; Object.defineProperty(this, 'suicide', { - get: function() { - // TODO: Print deprecation message. + get: internalUtil.deprecate(() => { return this.exitedAfterDisconnect; - }, - set: function(val) { - // TODO: Print deprecation message. + }, 'worker.suicide is deprecated. ' + + 'Please use worker.exitedAfterDisconnect.'), + set: internalUtil.deprecate((val) => { this.exitedAfterDisconnect = val; - }, + }, 'worker.suicide is deprecated. ' + + 'Please use worker.exitedAfterDisconnect.'), enumerable: true });