From e3cfbbaf57fa5542ebc71b9c9bb9c9b5cf65fa80 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 27 Aug 2019 14:55:40 -0700 Subject: [PATCH] test: fix flaky test-http-server-keepalive-req-gc Use `server` to keep the event loop open until the `ongc` listener runs. PR-URL: https://github.com/nodejs/node/pull/29347 Fixes: https://github.com/nodejs/node/issues/29344 Reviewed-By: Anna Henningsen Reviewed-By: Daniel Bevenius --- test/parallel/test-http-server-keepalive-req-gc.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/test/parallel/test-http-server-keepalive-req-gc.js b/test/parallel/test-http-server-keepalive-req-gc.js index aa4bf1a3de9c83..77defb5154676e 100644 --- a/test/parallel/test-http-server-keepalive-req-gc.js +++ b/test/parallel/test-http-server-keepalive-req-gc.js @@ -16,7 +16,7 @@ if (common.isWindows) { let client; const server = createServer(common.mustCall((req, res) => { - onGC(req, { ongc: common.mustCall() }); + onGC(req, { ongc: common.mustCall(() => { server.close(); }) }); req.resume(); req.on('end', common.mustCall(() => { setImmediate(() => { @@ -27,8 +27,6 @@ const server = createServer(common.mustCall((req, res) => { res.end('hello world'); })); -server.unref(); - server.listen(0, common.mustCall(() => { client = connect(server.address().port);