From db125c561880d8b2b272fb85c7a3baa91fcec31a Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Tue, 18 Feb 2020 14:52:15 -0500 Subject: [PATCH] doc: fix missing changelog corrections There was a slight discrepancy between the build of 12.16.1 and what landed on 12.x. This was only a couple spelling errors that didn't get updated between machines I was working on. This change gets the changelog up to date with what went out in the release vs what is current on the 12.x release branch. PR-URL: https://github.com/nodejs/node/pull/31854 Reviewed-By: Shelley Vohr Reviewed-By: Beth Griggs Reviewed-By: Gus Caplan Reviewed-By: Richard Lau --- doc/changelogs/CHANGELOG_V12.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/changelogs/CHANGELOG_V12.md b/doc/changelogs/CHANGELOG_V12.md index 80d7433f943bf1..6e621f8fef1026 100644 --- a/doc/changelogs/CHANGELOG_V12.md +++ b/doc/changelogs/CHANGELOG_V12.md @@ -85,7 +85,7 @@ Semver-Minor release. Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed -and the change could re land in a future Semver-Patch release if the regression is reliably fixed. +and the change could re-land in a future Semver-Patch release if the regression is reliably fixed. **New Enumerable Read-Only Property on EventEmitter breaks @types/extend** @@ -94,14 +94,14 @@ broke existing code that was using the `@types/extend` module for extending clas as `@types/extend` was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been -reverted but could re land in a future Semver-Minor release if a non breaking way +reverted but could re-land in a future Semver-Minor release if a non breaking way of applying it is found. **Exceptions in the HTTP parser were not emitting an uncaughtException** A refactoring to Node.js interanls resulted in a bug where errors in the HTTP -parser were not being emitted by `process.on('uncaughtException')`. The fix -to this bug has been included in this release. +parser were not being emitted by `process.on('uncaughtException')` when the `async_hooks` `after` +hook exists. The fix to this bug has been included in this release. ### Commits