From c60a7fa7383a983a0348e8876fdd84b04c353436 Mon Sep 17 00:00:00 2001
From: Artur G Vieira <vieira.artur.g@gmail.com>
Date: Mon, 15 May 2017 03:38:54 +0000
Subject: [PATCH] test: move net reconnect error test to sequential

The usage of common.PORT could cause undesired port collisions when run
in parallel. The following test was moved to sequential.
test-net-reconnect-error.js

PR-URL: https://github.com/nodejs/node/pull/13033
Refs: https://github.com/nodejs/node/issues/12376
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
---
 .../test-net-reconnect-error.js                       | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
 rename test/{parallel => sequential}/test-net-reconnect-error.js (90%)

diff --git a/test/parallel/test-net-reconnect-error.js b/test/sequential/test-net-reconnect-error.js
similarity index 90%
rename from test/parallel/test-net-reconnect-error.js
rename to test/sequential/test-net-reconnect-error.js
index d9a68e01d0706c..128feffc933ae3 100644
--- a/test/parallel/test-net-reconnect-error.js
+++ b/test/sequential/test-net-reconnect-error.js
@@ -27,22 +27,19 @@ const N = 20;
 let client_error_count = 0;
 let disconnect_count = 0;
 
-// Hopefully nothing is running on common.PORT
 const c = net.createConnection(common.PORT);
 
 c.on('connect', common.mustNotCall('client should not have connected'));
 
-c.on('error', function(e) {
-  console.error(`CLIENT error: ${e.code}`);
+c.on('error', common.mustCall((e) => {
   client_error_count++;
   assert.strictEqual('ECONNREFUSED', e.code);
-});
+}, N + 1));
 
-c.on('close', function() {
-  console.log('CLIENT disconnect');
+c.on('close', common.mustCall(() => {
   if (disconnect_count++ < N)
     c.connect(common.PORT); // reconnect
-});
+}, N + 1));
 
 process.on('exit', function() {
   assert.strictEqual(N + 1, disconnect_count);