From bf5c309b5eec0511a58825b7a59d2835bf00a3d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Fri, 5 May 2017 14:50:44 +0200 Subject: [PATCH] build: fix V8 build on FreeBSD Use the -D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1 flag because on FreeBSD std::pairs copy constructor is non-trivial. Refs: https://lists.freebsd.org/pipermail/freebsd-toolchain/2016-March/002094.html Refs: https://github.com/gliaskos/freebsd-chromium/blob/master/www/chromium/Makefile#L202-L205 PR-URL: https://github.com/nodejs/node/pull/12784 Reviewed-By: Gibson Fahnestock Reviewed-By: Ali Ijaz Sheikh Reviewed-By: Anna Henningsen --- common.gypi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common.gypi b/common.gypi index 2c061a7b0583e0..a97e12ae38c7f1 100644 --- a/common.gypi +++ b/common.gypi @@ -410,6 +410,9 @@ 'libraries': [ '-lelf' ], }], ['OS=="freebsd"', { + # Use this flag because on FreeBSD std::pairs copy constructor is non-trivial + # https://lists.freebsd.org/pipermail/freebsd-toolchain/2016-March/002094.html + 'cflags': [ '-D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1' ], 'ldflags': [ '-Wl,--export-dynamic', ],