test: fix defect path traversal tests

The test never actually tested what it claims to test because it did not properly insert separators before `..`. PR-URL: #50124 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
nodejs · Oct 23, 2023 · ae905a8 · ae905a8
1 parent 5df3d5a
commit ae905a8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/test/fixtures/permission/fs-traversal.js b/test/fixtures/permission/fs-traversal.js
@@ -12,9 +12,9 @@ path.resolve = (s) => s;
 
 const blockedFolder = process.env.BLOCKEDFOLDER;
 const allowedFolder = process.env.ALLOWEDFOLDER;
-const traversalPath = allowedFolder + '../file.md';
-const traversalFolderPath = allowedFolder + '../folder';
-const bufferTraversalPath = Buffer.from(allowedFolder + '../file.md');
+const traversalPath = allowedFolder + '/../file.md';
+const traversalFolderPath = allowedFolder + '/../folder';
+const bufferTraversalPath = Buffer.from(traversalPath);
 const uint8ArrayTraversalPath = new TextEncoder().encode(traversalPath);
 
 {

diff --git a/test/parallel/test-permission-fs-traversal-path.js b/test/parallel/test-permission-fs-traversal-path.js
@@ -18,7 +18,7 @@ const tmpdir = require('../common/tmpdir');
 
 const file = fixtures.path('permission', 'fs-traversal.js');
 const blockedFolder = tmpdir.path;
-const allowedFolder = tmpdir.resolve('subdirectory/');
+const allowedFolder = tmpdir.resolve('subdirectory');
 const commonPathWildcard = path.join(__filename, '../../common*');
 
 {