From a703bdecc4c2b28389fe2b8d87fb5de91e742889 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Mon, 3 Apr 2017 07:49:59 +0200 Subject: [PATCH] build: add checks for openssl configure options Currently it is possible to configure using --without-ssl and --shared-openssl/--openssl-no-asm/openssl-fips without an error occuring. The commit add check for these combinations: $ ./configure --without-ssl --shared-openssl Error: --without-ssl is incompatible with --shared-openssl $ ./configure --without-ssl --openssl-no-asm Error: --without-ssl is incompatible with --openssl-no-asm $ ./configure --without-ssl --openssl-fips=dummy Error: --without-ssl is incompatible with --openssl-fips PR-URL: https://github.com/nodejs/node/pull/12175 Reviewed-By: Ben Noordhuis Reviewed-By: Richard Lau --- configure | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/configure b/configure index 1eca3b0535ac33..06ccb26e9be2ab 100755 --- a/configure +++ b/configure @@ -977,6 +977,15 @@ def configure_openssl(o): if options.without_ssl: + def without_ssl_error(option): + print('Error: --without-ssl is incompatible with %s' % option) + exit(1) + if options.shared_openssl: + without_ssl_error('--shared-openssl') + if options.openssl_no_asm: + without_ssl_error('--openssl-no-asm') + if options.openssl_fips: + without_ssl_error('--openssl-fips') return configure_library('openssl', o)