Skip to content

Commit

Permalink
test: refactor test-util-inspect.js
Browse files Browse the repository at this point in the history
* Enclose tests that used to introduce module-level variables into
  their own scopes.
* Replace ES5 anonymous functions with arrow functions where it makes
  sense.
* And make one arrow function a regular function thus fixing a bug in a
  getter inside an object created in "Array with dynamic properties"
  test.  This getter has never been invoked though, so the test hasn't been
  failing.
* Convert snake_case identifiers to camelCase.
* Make some variable names more readable.
* Replace regular expressions in maxArrayLength tests with simple
  assert.strictEquals() and assert(...endsWith()) checks, as suggested
  in <#11576 (comment)>.

PR-URL: #11779
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
aqrln authored and evanlucas committed May 2, 2017
1 parent b1d3f59 commit 9bdf62f
Showing 1 changed file with 314 additions and 273 deletions.
Loading

0 comments on commit 9bdf62f

Please sign in to comment.