From 86a3ba0c4eb4b5226e805d1bc496b567be2e5664 Mon Sep 17 00:00:00 2001 From: Sebastian Plesciuc Date: Mon, 17 Apr 2017 18:18:41 +0300 Subject: [PATCH] test: dynamic port in cluster worker wait close Remove common.PORT from test-cluster-worker-wait-server-close possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: https://github.com/nodejs/node/pull/12466 Ref: https://github.com/nodejs/node/issues/12376 Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Santiago Gimeno --- test/parallel/test-cluster-worker-wait-server-close.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-cluster-worker-wait-server-close.js b/test/parallel/test-cluster-worker-wait-server-close.js index 7a0e5130f60ddb..a563d52beb3592 100644 --- a/test/parallel/test-cluster-worker-wait-server-close.js +++ b/test/parallel/test-cluster-worker-wait-server-close.js @@ -12,7 +12,7 @@ if (cluster.isWorker) { // Wait for any data, then close connection socket.write('.'); socket.on('data', common.noop); - }).listen(common.PORT, common.localhostIPv4); + }).listen(0, common.localhostIPv4); server.once('close', function() { serverClosed = true; @@ -33,8 +33,8 @@ if (cluster.isWorker) { const worker = cluster.fork(); // Disconnect worker when it is ready - worker.once('listening', function() { - const socket = net.createConnection(common.PORT, common.localhostIPv4); + worker.once('listening', function(address) { + const socket = net.createConnection(address.port, common.localhostIPv4); socket.on('connect', function() { socket.on('data', function() {