From 7a7c194f4eb7866b39c6443a2d3762117c646619 Mon Sep 17 00:00:00 2001 From: Jon Moss Date: Fri, 20 Jul 2018 11:21:57 -0400 Subject: [PATCH] tools: fix docs and run known_issues by default - Updates `test/README.md` with new suites - Fixes some outdated `IGNORED_SUITES` listings - Allows for `test/known_issues` suite to be run by default PR-URL: https://github.com/nodejs/node/pull/21910 Reviewed-By: Vse Mozhet Byt Reviewed-By: James M Snell Reviewed-By: Lance Ball Reviewed-By: Richard Lau Reviewed-By: Rich Trott --- test/README.md | 10 +++++++--- tools/test.py | 2 -- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/test/README.md b/test/README.md index df95cedb340b3b..510d7c39966c8d 100644 --- a/test/README.md +++ b/test/README.md @@ -16,9 +16,13 @@ GitHub with the `autocrlf` git config flag set to true. |Directory |Runs on CI |Purpose | |-------------------|---------------|---------------| |abort |Yes |Tests for when the ``` --abort-on-uncaught-exception ``` flag is used.| -|addons |Yes |Tests for [addon](https://nodejs.org/api/addons.html) functionality along with some tests that require an addon to function properly.| -|cctest |Yes |C++ test that is run as part of the build process.| +|addons |Yes |Tests for [addon](https://nodejs.org/api/addons.html) functionality along with some tests that require an addon to function properly.| +|addons-napi |Yes |Tests for [n-api](https://nodejs.org/api/n-api.html) functionality.| +|async-hooks |Yes |Tests for [async_hooks](https://nodejs.org/api/async_hooks.html) functionality.| +|cctest |Yes |C++ tests that are run as part of the build process.| +|code-cache |No |Tests for a Node.js binary compiled with V8 code cache.| |common | |Common modules shared among many tests. [Documentation](./common/README.md)| +|doctool |Yes |Tests for the documentation generator.| |es-module |Yes |Test ESM module loading.| |fixtures | |Test fixtures used in various tests throughout the test suite.| |internet |No |Tests that make real outbound connections (mainly networking related modules). Tests for networking related modules may also be present in other directories, but those tests do not make outbound connections.| @@ -30,7 +34,7 @@ GitHub with the `autocrlf` git config flag set to true. |sequential |Yes |Various tests that are run sequentially.| |testpy | |Test configuration utility used by various test suites.| |tick-processor |No |Tests for the V8 tick processor integration. The tests are for the logic in ```lib/internal/v8_prof_processor.js``` and ```lib/internal/v8_prof_polyfill.js```. The tests confirm that the profile processor packages the correct set of scripts from V8 and introduces the correct platform specific logic.| -|timers |No |Tests for [timing utilities](https://nodejs.org/api/timers.html) (```setTimeout``` and ```setInterval```).| +|v8-updates |No |Tests for V8 performance integration.| _When a new test directory is added, make sure to update the `CI_JS_SUITES` variable in the `Makefile` and the `js_test_suites` variable in diff --git a/tools/test.py b/tools/test.py index 6e96e22192102f..b6f91aa1ebdf59 100755 --- a/tools/test.py +++ b/tools/test.py @@ -1540,9 +1540,7 @@ def PrintCrashed(code): 'doctool', 'internet', 'pummel', - 'test-known-issues', 'tick-processor', - 'timers', 'v8-updates' ]