Skip to content

Commit

Permalink
http: remove variable redeclaration
Browse files Browse the repository at this point in the history
In lib/_http_client.js, the variable `conn` was declared with the `var`
keyword three times in the same scope. This change eliminates the
variable entirely.

PR-URL: #4612
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott authored and Myles Borins committed Jan 12, 2016
1 parent 37a546b commit 787c5d9
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions lib/_http_client.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,7 @@ function ClientRequest(options, cb) {
if (self.socketPath) {
self._last = true;
self.shouldKeepAlive = false;
var conn = self.agent.createConnection({ path: self.socketPath });
self.onSocket(conn);
self.onSocket(self.agent.createConnection({ path: self.socketPath }));
} else if (self.agent) {
// If there is an agent we should default to Connection:keep-alive,
// but only if the Agent will actually reuse the connection!
Expand All @@ -141,12 +140,11 @@ function ClientRequest(options, cb) {
self._last = true;
self.shouldKeepAlive = false;
if (options.createConnection) {
var conn = options.createConnection(options);
self.onSocket(options.createConnection(options));
} else {
debug('CLIENT use net.createConnection', options);
var conn = net.createConnection(options);
self.onSocket(net.createConnection(options));
}
self.onSocket(conn);
}

self._deferToConnect(null, null, function() {
Expand Down

0 comments on commit 787c5d9

Please sign in to comment.