From 4839fc4369712cf815a09bc150fb5a9d77abaf3a Mon Sep 17 00:00:00 2001 From: Khafra Date: Tue, 11 Apr 2023 11:24:30 -0400 Subject: [PATCH] url: validate argument length in canParse PR-URL: https://github.com/nodejs/node/pull/47513 Reviewed-By: Yagiz Nizipli Reviewed-By: Benjamin Gruenbaum Reviewed-By: Tiancheng "Timothy" Gu Reviewed-By: Luigi Pinca Reviewed-By: Filip Skokan --- lib/internal/url.js | 4 ++++ test/parallel/test-url-canParse-whatwg.js | 12 ++++++++++++ 2 files changed, 16 insertions(+) create mode 100644 test/parallel/test-url-canParse-whatwg.js diff --git a/lib/internal/url.js b/lib/internal/url.js index cb662b90ac052c..b6412dd6a5480b 100644 --- a/lib/internal/url.js +++ b/lib/internal/url.js @@ -978,6 +978,10 @@ class URL { } static canParse(url, base = undefined) { + if (arguments.length === 0) { + throw new ERR_MISSING_ARGS('url'); + } + url = `${url}`; if (base !== undefined) { diff --git a/test/parallel/test-url-canParse-whatwg.js b/test/parallel/test-url-canParse-whatwg.js new file mode 100644 index 00000000000000..997c90c343c2f2 --- /dev/null +++ b/test/parallel/test-url-canParse-whatwg.js @@ -0,0 +1,12 @@ +'use strict'; + +require('../common'); +const assert = require('assert'); + +// One argument is required +assert.throws(() => { + URL.canParse(); +}, { + code: 'ERR_MISSING_ARGS', + name: 'TypeError' +});