From 481789c235cbf77e0a0f991567acae0ab15dc5d5 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Sun, 21 Apr 2019 09:50:59 +0200 Subject: [PATCH] tools: fix use-after-free mkcodecache warning Call `v8::Platform::ShutdownPlatform()` to fix a Coverity warning about the `v8::Platform` instance being deleted when it's still in use. PR-URL: https://github.com/nodejs/node/pull/27332 Reviewed-By: Joyee Cheung Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig --- tools/code_cache/mkcodecache.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/code_cache/mkcodecache.cc b/tools/code_cache/mkcodecache.cc index 24f7e05e1f19f7..defa1462ce45ec 100644 --- a/tools/code_cache/mkcodecache.cc +++ b/tools/code_cache/mkcodecache.cc @@ -58,5 +58,6 @@ int main(int argc, char* argv[]) { out.close(); } + v8::V8::ShutdownPlatform(); return 0; }