Skip to content

Commit

Permalink
test: change ciphers from RC4 to no-such-cipher
Browse files Browse the repository at this point in the history
This commit updates option ciphers from 'RC4' to 'no-such-cipher' in
test/parallel/test-tls-handshake-error.js.

The motivation for this change is that this test is verifying that a
'no ciphers match' error be thrown, but 'RC4' might be among the ciphers
supported by the OpenSSL version when dynamically linking. I ran into
this specific issue when dynamically linking against OpenSSL 1.1.1 on
RHEL8 using #25381.

PR-URL: #25534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
danbev authored and addaleax committed Jan 23, 2019
1 parent d9da4af commit 3dcdf27
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/parallel/test-tls-handshake-error.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const server = tls.createServer({
assert.throws(() => {
tls.connect({
port: this.address().port,
ciphers: 'RC4'
ciphers: 'no-such-cipher'
}, common.mustNotCall());
}, /no cipher match/i);

Expand Down

0 comments on commit 3dcdf27

Please sign in to comment.