Skip to content

Commit

Permalink
build: turn on custom V8 snapshot by default
Browse files Browse the repository at this point in the history
This patch re-enables custom V8 snapshot integration. Also renames
the experimental configure switch from `--with-node-snapshot`
to `--without-node-snapshot` to be consistent with`--without-snapshot`
which is used for the default V8 snapshot.

PR-URL: #28181
Refs: #27365
Refs: #17058
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
joyeecheung authored and BridgeAR committed Jun 17, 2019
1 parent 9085412 commit 2201484
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -421,10 +421,10 @@
dest='with_ltcg',
help='Use Link Time Code Generation. This feature is only available on Windows.')

parser.add_option('--with-node-snapshot',
parser.add_option('--without-node-snapshot',
action='store_true',
dest='with_node_snapshot',
help='Turn on V8 snapshot integration. Currently experimental.')
dest='without_node_snapshot',
help='Turn off V8 snapshot integration. Currently experimental.')

intl_optgroup.add_option('--download',
action='store',
Expand Down Expand Up @@ -942,11 +942,9 @@ def configure_node(o):
o['variables']['want_separate_host_toolset'] = int(
cross_compiling and want_snapshots)

if options.with_node_snapshot:
o['variables']['node_use_node_snapshot'] = 'true'
if not options.without_node_snapshot:
o['variables']['node_use_node_snapshot'] = b(not cross_compiling)
else:
# Default to false for now.
# TODO(joyeecheung): enable it once we fix the hashseed uniqueness
o['variables']['node_use_node_snapshot'] = 'false'

if target_arch == 'arm':
Expand Down

0 comments on commit 2201484

Please sign in to comment.