Skip to content

Commit

Permalink
report: fix recent coverity warning
Browse files Browse the repository at this point in the history
Fix warning about dereferencing null env

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #48954
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
mhdawson authored and UlisesGascon committed Sep 10, 2023
1 parent f637fd4 commit 173aed4
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions src/node_report.cc
Original file line number Diff line number Diff line change
Expand Up @@ -857,9 +857,13 @@ std::string TriggerNodeReport(Isolate* isolate,
// Determine the required report filename. In order of priority:
// 1) supplied on API 2) configured on startup 3) default generated
if (!name.empty()) {
THROW_IF_INSUFFICIENT_PERMISSIONS(
env, permission::PermissionScope::kFileSystemWrite, name, name);
// Filename was specified as API parameter.
// we may not always be in a great state when generating a node report
// allow for the case where we don't have an env
if (env != nullptr) {
THROW_IF_INSUFFICIENT_PERMISSIONS(
env, permission::PermissionScope::kFileSystemWrite, name, name);
// Filename was specified as API parameter.
}
filename = name;
} else {
std::string report_filename;
Expand Down

0 comments on commit 173aed4

Please sign in to comment.