Skip to content

Commit

Permalink
test: fix helper-debugger-repl.js
Browse files Browse the repository at this point in the history
The test `debugger/test-debugger-repl-break-in-module` (and probably
others) was failing because the handshake message for debugging is no
longer `listening on port <port>` but is instead `listening on
<address>:<port>`.

This change makes the check less strict so as to hopefully future-proof
it at least a little bit against subsequent changes.

This test failure is not caught in CI because currently debugger tests
are not run in CI.

PR-URL: #9486
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
  • Loading branch information
Trott authored and MylesBorins committed Dec 21, 2016
1 parent aebbc96 commit 13cace1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/debugger/helper-debugger-repl.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ function addTest(input, output) {
}

var handshakeLines = [
/listening on port \d+/,
/listening on /,
/connecting.* ok/
];

Expand Down

0 comments on commit 13cace1

Please sign in to comment.