From 16b5776227d55b3f7b90f5a23e531f7c12b1836d Mon Sep 17 00:00:00 2001 From: "Steven R. Loomis" Date: Fri, 5 Oct 2018 09:31:10 -0700 Subject: [PATCH] git-node: Clarify that the wait time is a *minimum* not a maximum. --- lib/pr_checker.js | 2 +- test/unit/pr_checker.test.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/pr_checker.js b/lib/pr_checker.js index 591a2c97..dfe571e8 100644 --- a/lib/pr_checker.js +++ b/lib/pr_checker.js @@ -185,7 +185,7 @@ class PRChecker { const dateStr = new Date(pr.createdAt).toDateString(); const type = wait.isWeekend ? 'weekend' : 'weekday'; cli.info(`This PR was created on ${dateStr} (${type} in UTC)`); - cli.warn(`${wait.timeLeft} hours left to land`); + cli.warn(`Wait at least ${wait.timeLeft} more hours before landing`); return false; } diff --git a/test/unit/pr_checker.test.js b/test/unit/pr_checker.test.js index e2a50cb6..6d22329f 100644 --- a/test/unit/pr_checker.test.js +++ b/test/unit/pr_checker.test.js @@ -169,7 +169,7 @@ describe('PRChecker', () => { const cli = new TestCLI(); const expectedLogs = { - warn: [['49 hours left to land']], + warn: [['Wait at least 49 more hours before landing']], info: [['This PR was created on Sat Oct 28 2017 (weekend in UTC)']] }; @@ -201,7 +201,7 @@ describe('PRChecker', () => { const cli = new TestCLI(); const expectedLogs = { - warn: [['22 hours left to land']], + warn: [['Wait at least 22 more hours before landing']], info: [['This PR was created on Tue Oct 31 2017 (weekday in UTC)']] };