From 015bf203aecb918d9af7949280c9b8c936fef7b7 Mon Sep 17 00:00:00 2001 From: Yagiz Nizipli Date: Wed, 14 Jun 2023 19:01:11 -0400 Subject: [PATCH] fix(git-node): properly terminate pr landing sessions (#708) Fixes: https://github.com/nodejs/node-core-utils/issues/707 --- lib/landing_session.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/landing_session.js b/lib/landing_session.js index 3facf6b4..269f4d6a 100644 --- a/lib/landing_session.js +++ b/lib/landing_session.js @@ -62,8 +62,8 @@ export default class LandingSession extends Session { const shouldContinue = await cli.prompt( `This PR ${status} to land, do you want to continue?`, { defaultAnswer }); if (!shouldContinue) { - cli.setExitCode(1); - return this.abort(false); + await this.abort(false); + return process.exit(1); } this.saveMetadata(metadata);