Update dependencies for node 8 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemaex
commented
Jan 10, 2018
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| var fs = require('fs') | |||
| var http = require('http') | |||
| var connect = require('connect') | |||
| var body = require('body-parser') | |||
There was a problem hiding this comment.
Express 4 moved all content parsers into their own package - I removed connect and added that new one
| @@ -11,7 +11,7 @@ function DMX4ALL(device_id, options) { | |||
| this.universe.fill(0) | |||
|
|
|||
| this.dev = new SerialPort(device_id, { | |||
| 'baudrate': 38400, | |||
| 'baudRate': 38400, | |||
There was a problem hiding this comment.
New syntax of the serial port package
| @@ -48,14 +48,11 @@ function DMXWeb() { | |||
| } | |||
| } | |||
| }) | |||
| io.set('log level', 1) | |||
There was a problem hiding this comment.
newer version of socket.io use the debug npm package, easy debugging via DEBUG=* ./dmx-web.js
wiedi
approved these changes
Jan 10, 2018
Fensterbank
approved these changes
Jan 10, 2018
|
@wiedi @Fensterbank thank you for reviewing! I'll merge this PR and release a new version then 🎉 |
This was referenced Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all the dependencies to their current versions as of today. I have this new setup running successfully on Node 8.9.4
Merging this pull request fixes #25 and make #31, #32, #33 obsolete.