Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codebase to recover compatibility #33

Closed
wants to merge 5 commits into from

Conversation

Fensterbank
Copy link
Member

This pull request merges relevant commits from another fork to the main repository.
Source code is updated to ES2015+ and the packages are updated to the latest major version to recover compatibility with Node 7+.

Merging this pull request fixes #25 and makes #31 and #32 obsolete.

@Fensterbank Fensterbank closed this Jan 3, 2018
@Fensterbank
Copy link
Member Author

missed a few things.

@Fensterbank Fensterbank reopened this Jan 6, 2018
@Fensterbank
Copy link
Member Author

now all things are done and the PR is ready to merge.
@wiedi would you please check this and the other pull requests?

@wiedi
Copy link
Member

wiedi commented Jan 8, 2018

Hi, thanks for picking this up and apologies for the delay!

There's a lot going on in this PR.

  • devices.js looks fine
  • if we'd decide to ship an example dmx-web.json maybe better to rename the existing one?
  • package.json - should not change the url, why is color-convert a dev-dependency?
  • pliabAnim.js - what does "pliab" stand for? Maybe this deserves a note/example in the readme?

@Fensterbank
Copy link
Member Author

Fensterbank commented Jan 8, 2018

Oh, yes. You're right.
It seems with the commits of thomfort we have a few more weird things we don't want or need. I did not notice this.
I think I will recreate my branch by concentrating on package upgrades and ignoring the other commits from thomfort. Stay tuned...

@Fensterbank
Copy link
Member Author

Obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working on node version 7.x.x
3 participants