-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working on node version 7.x.x #25
Comments
Thank you for the report. I don't have an immediate answer. Maybe the js stack trace includes helpful information? |
Oh yes, |
You were right. It appears that serialport@4.0.7 is the latest package in the npm repos. I tried with Running
I would love to do some testing and do a Pull Request for you but I'm out of time at the moment. |
Just had an update from the team over at serialport. I reported to them that version 4 is the only version I saw available in the npm reops. Now they have updated and |
Hi, I had the same problem recently, I'm using Node 6.10.2. I solved it using the git version of the library and not the one listed in the 'npm' repos (which is older). |
If anyone is interested in a temp fix, I've forked node-dmx and updated the serialport dependency ref to 5.0.0-beta. Also made a simple change to
|
The state of backwards compatibility with node and node-serialport is somewhat depressing. I'm not so sure about adding a beta version as a dependency. Especially as it seems to drop support for everything before node 8. |
@wiedi Agreed. I don't think you should add a beta dependency, especially considering a 5.0 release may happen soon. I just needed to get the lib working in a short amount of time for a project and wanted to report back the results of my testing w/ a new version of serialport. |
@westhom You totally saved my week with that fork. Thanks for publishing! |
Just released 0.0.6 by a small delay - which now has updated dependencies and works on node 8 and 9 again 🎉 |
I'm running this in node 6.9.4 and I get the following in the terminal on running the script.
I'm guessing that there is some piece of a dependency that node-dmx uses
v8::ObjectTemplate::Set()
. How can I help find the corresponding dependency and see if there is an update to get node-dmx working in node v7.x.x?The text was updated successfully, but these errors were encountered: