Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty section with key declaration is not detected as empty #656

Closed
no-chris opened this issue Jan 25, 2024 · 0 comments · Fixed by #657
Closed

Empty section with key declaration is not detected as empty #656

no-chris opened this issue Jan 25, 2024 · 0 comments · Fixed by #657
Assignees
@no-chris
Labels
bug Something isn't working
Milestone
ChordMark 1.0

Comments

@no-chris
Copy link
Owner 

#v
verse 
verse

#c
chorus
chorus

#v

3/4
key A
#o
outro

=>

Verse 1
verse 
verse
 
Chorus
chorus
chorus
 
Verse 2
 
3/4
key: A
Outro
outro

instead of:

Verse 1
verse 
verse
 
Chorus
chorus
chorus
 
Verse 2
verse 
verse
 
3/4
key: A
Outro
outro
@no-chris no-chris added the bug Something isn't working label Jan 25, 2024
@no-chris no-chris self-assigned this Jan 25, 2024
@no-chris no-chris added this to the ChordMark 1.0 milestone Jan 25, 2024
@no-chris no-chris mentioned this issue Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@no-chris no-chris

Labels
bug Something isn't working
Projects
The ChordMark Project
Status: Archive
Milestone
ChordMark 1.0
Development

Successfully merging a pull request may close this issue.

Do not consider key declarations when detecting empty sections no-chris/chord-mark
1 participant
@no-chris