Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning C4706 - Visual Studio 2017 (/W4) #784

Closed
jseward opened this issue Oct 16, 2017 · 2 comments
Closed

warning C4706 - Visual Studio 2017 (/W4) #784

jseward opened this issue Oct 16, 2017 · 2 comments
Assignees
@nlohmann
Labels
platform: visual studio related to MSVC
Milestone
Release 3.0.0

Comments

@jseward
Copy link
Contributor

jseward commented Oct 16, 2017 

json.hpp(3037): warning C4706: assignment within conditional expression
json.hpp(3133): warning C4706: assignment within conditional expression

It looks like this was discussed and solved already for VS 2015 here : #295

But the issue remains on VS 2017
@nlohmann nlohmann added the platform: visual studio related to MSVC label Oct 16, 2017
@nlohmann
Copy link
Owner

The assignment is OK here, and it is surrounded by parentheses which silences GCC and Clang. Maybe, adding pragmas could help here. I have to check #295 again.

@nlohmann nlohmann added this to the Release 3.0.0 milestone Oct 16, 2017
@nlohmann nlohmann self-assigned this Oct 16, 2017
@nlohmann
Copy link
Owner

Fixed with #785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
platform: visual studio related to MSVC
Projects
None yet
Milestone
Release 3.0.0
Development

No branches or pull requests
2 participants
@nlohmann @jseward