Fix invalid JSON format for ${aspnet-request-cookie} and ${aspnet-request-querystring}, added extra formatting options, consistent rendering of multiple values #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
304NotModified
force-pushed
the
cookies_tests_on_core
branch
from
9ff2e1d
to
ed3ef5e
Compare
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 59.03% 62.68% +3.64%
==========================================
Files 25 26 +1
Lines 310 343 +33
Branches 77 82 +5
==========================================
+ Hits 183 215 +32
Misses 91 91
- Partials 36 37 +1
Continue to review full report at Codecov.
|
304NotModified
changed the title
304NotModified
changed the title
304NotModified
changed the title
304NotModified
commented
May 6, 2017
| @@ -98,7 +98,7 @@ public void KeyFoundRendersValue_QueryString_Single_Item_Json_Formatting() | |||
| [Fact] | |||
| public void KeyFoundRendersValue_QueryString_Multiple_Item_Flat_Formatting() | |||
| { | |||
| var expectedResult = "Id:1," + Environment.NewLine + "Id2:2"; | |||
| var expectedResult = "Id=1,Id2=2"; | |||
| @@ -113,7 +113,7 @@ public void KeyFoundRendersValue_QueryString_Multiple_Item_Flat_Formatting() | |||
| [Fact] | |||
| public void EmptyProperyShouldListAll() | |||
| { | |||
| var expectedResult = "Id:1," + Environment.NewLine + "Id2:2"; | |||
304NotModified
force-pushed
the
cookies_tests_on_core
branch
from
96910f1
to
32be01d
Compare
304NotModified
changed the title
304NotModified
added
ASP.NET 4
snakefoot
added
ASP.NET Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No breaking changes in config, but change in output of multiple values. It's now consistent and configurable.
fixes #119
todo:
:or=-> option