-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest version has broken the insert URL link functionality #2687
Comments
Bug is partly duplicate with #2671 but not completely - some of the errors are not new:
|
mark. |
Seems like some kind of bundling error. Like the react-editor isn't handling the dependency on @tui/editor right when building it. Then again this could be caused by my bundling system as I'm using dynamic import with nextjs to load the editor |
Seems to be because build inserted I pulled this project and ran |
No, wait, I fixed it on accident by removing an unnecessary cast and typescript suppression :D I'll put up an MR. |
@jethrolarson Thank you! Weirdly enough it is working for me locally, but not on my Vercel deployed Next.js app. Hoping your PR fixes the issue though |
I spotted this as well after having run into the issue via both Hugo's internal ESbuild pipe and Snowpack; glad to see a resolution is in sight! |
check v3.2.1 please, if you use react or vue wrapper, you need to use v3.2.2 |
Describe the bug
After the update to the @toast-ui/editor@3.2.0 the dialog for URL link insert fails.
When started in the debug mode, The debuger raises an exception getCustomAttrs is not defined at line 19255 (in the transpilled code).
To Reproduce
Steps to reproduce the behavior:
Expected behaviour
As before update - simply insert the link
Screenshots
If applicable, add screenshots to help explain your problem.
The OK button doesn't close the window.
However, when closed using the Cancel (Zrušit on the image), link is visible - but only in the markdown:
Unfortunately, save fails with an exception and change is not saved. Doing again and saving without former switching to the markdown passes, but the text is converted to the string code:
With the markdown:
What's worse, the same problem occurs when I am trying to insert the link directly in the markdowns without using the dialog:
it puts several ~to the code and when debugged it always fails with the error:
and application hangs up.
Additional context
The used modules are:
aymine.com@5.56.7
├── @babel/core@7.18.10
├── @babel/plugin-proposal-class-properties@7.18.6
├── @babel/plugin-proposal-object-rest-spread@7.18.9
├── @babel/preset-env@7.18.10
├── @babel/preset-typescript@7.18.6
├── @rollup/plugin-alias@3.1.9
├── @rollup/plugin-babel@5.3.1
├── @rollup/plugin-commonjs@15.1.0
├── @rollup/plugin-node-resolve@9.0.0
├── @toast-ui/chart@4.4.3
├── @toast-ui/editor@3.2.0
├── check-dependencies@1.1.0
├── composer@4.1.0
├── npm-dts@1.3.12
├── npm@8.18.0
├── rollup-cache@1.2.0
├── rollup-plugin-terser@7.0.2
├── rollup-plugin-typescript2@0.27.3
├── rollup@2.78.1
├── tui-calendar@1.15.3
├── tui-code-snippet@2.3.3
├── tui-color-picker@2.2.8
├── tui-tree@4.0.9
└── typescript@4.7.4
The text was updated successfully, but these errors were encountered: