Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows DLL missing version information and other file properties #182

Open
geraldcombs opened this issue Dec 26, 2023 · 2 comments
Open
Labels

Comments

@geraldcombs
Copy link

The nghttp2 sources have a resource file that sets the ProductName, ProductVersion, and other properties: https://github.com/nghttp2/nghttp2/blob/master/lib/version.rc.in. A corresponding file appears to be missing in this repository, and generated DLLs don't have those properties set. Would it be possible to add this?

@tatsuhiro-t
Copy link
Member

Thank you for reporting this issue. If anyone is interested in it. please send a pull request to add the file.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants