From a316a3a2312da6d2288e2b04a8f189378897b5f7 Mon Sep 17 00:00:00 2001 From: kevinmenden Date: Mon, 22 Mar 2021 20:45:14 +0100 Subject: [PATCH 1/2] better logging for directory --- nf_core/modules/create.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/nf_core/modules/create.py b/nf_core/modules/create.py index ea35b54c29..89340ecf94 100644 --- a/nf_core/modules/create.py +++ b/nf_core/modules/create.py @@ -251,7 +251,10 @@ def get_repo_type(self, directory): elif os.path.exists(os.path.join(directory, "software")): return "modules" else: - raise UserWarning(f"Could not determine repository type: '{directory}'") + raise UserWarning( + f"This directory does not look like a clone of nf-core/modules or an nf-core pipeline: '{directory}'" + " Please point to a valid directory." + ) def get_module_dirs(self): """Given a directory and a tool/subtool, set the file paths and check if they already exist From b3c1d93d126eacda102efb5518c6f7a0b7b5796f Mon Sep 17 00:00:00 2001 From: kevinmenden Date: Mon, 22 Mar 2021 20:51:29 +0100 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7c56c0cb0e..326eb9c891 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,9 @@ # nf-core/tools: Changelog -## v1.14dev +## v1.13.2 -_..nothing yet.._ +* Added better logging message if a user doesn't specificy the directory correctly with `nf-core modules` commands [[#942](https://github.com/nf-core/tools/pull/942)] +* Fixed parameter validation bug caused by JSONObject [[#937](https://github.com/nf-core/tools/issues/937)] ## [v1.13.1 - Copper Crocodile Patch :crocodile: :pirate_flag:](https://github.com/nf-core/tools/releases/tag/1.13.1) - [2021-03-19]