Template: remove try-catch blocks from nextflow.config

[mirpedrol]

Close #3132

[mirpedrol]

One problem with this syntax is that the first time a user creates a pipeline, this will fail as nf-core/configs does not contain the pipeline config.
It can be solved by providing a false params.custom_config_base but it's not ideal. I would consider commenting out these lines on the template again and let users decide if they want to include a pipeline specific config.

[ewels]

I would consider commenting out these lines on the template again and let users decide if they want to include a pipeline specific config.

Agree 👍🏻

Suggested change

	includeConfig !System.getenv('NXF_OFFLINE') && params.custom_config_base ? "${params.custom_config_base}/pipeline/{{ short_name }}.config" : "/dev/null"
	// includeConfig !System.getenv('NXF_OFFLINE') && params.custom_config_base ? "${params.custom_config_base}/pipeline/{{ short_name }}.config" : "/dev/null"

[jfy133]

Does this mean that a pipeline developer has to do this?

If so I don't like that idea so much as it never gets uncommented (as much people don't know about it), but then you have users come along asking for the support which then requires a whole new release of the pipeline.

We specifically added automatically generated the 'dummy' configs to nf-core/configs recently so it's a seamless experience. A pipeline developer just needs to wait overnight for the dummy configs to be added (with the caveat the pipeline has to be under the nf-core organisation).

The other solution I can think to get around this: is to comment it out, but make a release linting error that it must be uncommented before release. Thus from first release it's supported

[mirpedrol]

The problem now is that without the try/except it will fail right after you use nf-core pipelines create, because the config is not added yet to nf-core.
The release linting error sounds like a good solution to me :)