Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev -> Master for v2.9 #2349

Merged
merged 327 commits into from
Jun 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
327 commits
Select commit Hold shift + click to select a range
33d0381
Split history ./modules/modules_repo.py to synced_repo.py
MatthiasZepper Feb 21, 2023
caef187
Duplication of ModulesRepo to SyncedRepo done.
MatthiasZepper Feb 21, 2023
2367ae7
Strip ModulesRepo class of the methods moved to new superclass.
MatthiasZepper Feb 21, 2023
f5f0df2
Rebase to current dev.
MatthiasZepper Feb 21, 2023
f852159
Local caching of the repo works now.
MatthiasZepper Feb 21, 2023
af4754e
Started implementing the config download.
MatthiasZepper Feb 22, 2023
3bc97c5
Started to implement the multiple revision selection for the Tower do…
MatthiasZepper Feb 24, 2023
e17a8e9
Rewrite get_revision_hash() function to accomodate multiple revisions.
MatthiasZepper Feb 28, 2023
ecaabf8
The 2nd revivial of the config choice. Now available for archives wit…
MatthiasZepper Feb 28, 2023
6d04ec8
Inclusion of the revision in the output file name is problematic with…
MatthiasZepper Mar 4, 2023
7642e4f
Allow multiple instances of the -r argument. Needed for scripted down…
MatthiasZepper Mar 8, 2023
7f93edb
Finished updating the prompts for the dialogues.
MatthiasZepper Mar 28, 2023
12bf942
Converted the self.wf_download_url into a dict.
MatthiasZepper Apr 13, 2023
2ff62f3
Enable multi-revision classic download.
MatthiasZepper Apr 14, 2023
986f791
Small tweaks to ensure that tools doesn't bail out if there is no sym…
MatthiasZepper Apr 17, 2023
6f95829
Initialise the Git repo clone of the workflow.
MatthiasZepper Apr 18, 2023
760fcaa
WorkflowRepo attributes and functions.
MatthiasZepper Apr 19, 2023
c381776
Finished the Tower download branch.
MatthiasZepper Apr 21, 2023
526a26e
Minor tweaks to the container download functionality.
MatthiasZepper Apr 24, 2023
f4b9e67
Updating docs and changelog, fixing linting errors.
MatthiasZepper Apr 24, 2023
2bf14bd
Hopefully fixed the existing tests. New ones still need to be written.
MatthiasZepper Apr 24, 2023
8de588e
Refactor the CLI commands for the Singularity Cache Dir
MatthiasZepper Apr 25, 2023
d729bde
Readme updates for the new remote Singularity cache feature.
MatthiasZepper Apr 26, 2023
0f58c29
Add interactive check in retry for parsing the index.
MatthiasZepper Apr 27, 2023
6294d74
Incorporating some suggestions by @mashehu.
MatthiasZepper Apr 27, 2023
8d327a4
Apply suggestions from code review @mashehu
MatthiasZepper Apr 27, 2023
340c519
Writing additional tests for the --tower download functionality.
MatthiasZepper Apr 27, 2023
f599237
Move alterations from Version 2.8 (which this PR didn't make anymore)…
MatthiasZepper May 2, 2023
2518a4b
Adding the info about remote containers to the summary log rather tha…
MatthiasZepper May 2, 2023
4f390be
Moved the notification about remote containers to summary_log.
MatthiasZepper May 5, 2023
f8e5068
Apply suggestions from code review
MatthiasZepper May 9, 2023
e512878
Fixes suggested by @mirpedrol during review. Thanks!
MatthiasZepper May 9, 2023
315b9a3
@mashehu suggested that downloading the containers should not be opti…
MatthiasZepper May 9, 2023
2ee34a2
avoid a blocking request call on first cli call
mashehu May 26, 2023
74c4e38
Merge branch 'dev' of https://github.com/nf-core/tools into improve-perf
mashehu May 26, 2023
766b87a
improved version of the async call
mashehu May 26, 2023
397ddec
add manual overwrite option for tests
mashehu May 26, 2023
9d809b6
Merge pull request #2296 from mashehu/improve-perf
mashehu May 26, 2023
6a806ee
Bugfix: WorkflowRepo.tidy_tags() did indeed only tidy tags. However, …
MatthiasZepper May 26, 2023
822e14f
rm outdated Dockerfile
SusiJo May 30, 2023
c4d851d
Merge branch 'dev' into fix_contributing
SusiJo May 30, 2023
ef62904
Merge pull request #2293 from SusiJo/fix_contributing
SusiJo May 30, 2023
259afa6
Merge branch 'dev' into DownloadForTower
MatthiasZepper May 31, 2023
a70a3fe
add version and subpath to multiqc report comment link
mashehu Jun 1, 2023
f016eae
update changelog
mashehu Jun 1, 2023
63e9b8b
also add version to main link
mashehu Jun 1, 2023
df9dee5
fix linting test
mashehu Jun 1, 2023
36c9284
update multiqc_config during version bump
mashehu Jun 1, 2023
531f977
bump version in multiqc_config correctly
mashehu Jun 1, 2023
138339a
Merge pull request #2247 from MatthiasZepper/DownloadForTower
MatthiasZepper Jun 1, 2023
4b1a3b8
Merge pull request #2298 from mashehu/fix-report-comment
mashehu Jun 1, 2023
6bbbd4a
Small bugfixes.
MatthiasZepper Jun 1, 2023
646a566
Merge pull request #2275 from nf-core/schema_display
maxulysse Jun 3, 2023
b634573
validate pipeline parameters with nf-validation
mirpedrol Jun 5, 2023
df79197
fix ch_input
mirpedrol Jun 5, 2023
6e4c582
add parameter defaults to schema to avoid printing them with paramete…
mirpedrol Jun 5, 2023
2cf0814
check if input file exists
mirpedrol Jun 5, 2023
8353340
Update seqeralabs/action-tower-launch to v1.2.4
adamrtalbot Jun 6, 2023
410db78
Update action to v2.0.0 (breaking change)
adamrtalbot Jun 6, 2023
0519307
update nf-validation to v0.2.1
mirpedrol Jun 7, 2023
81595ec
check paths exist with schema
mirpedrol Jun 7, 2023
e749f08
add comment about creating a channel with fromSamplesheet
mirpedrol Jun 7, 2023
d9b7b27
print help before initialise
mirpedrol Jun 7, 2023
e36fdbf
fix trailing whitespaces
mirpedrol Jun 7, 2023
e74f588
Adds `d` to the pattern of max_time
nvnieuwk Jun 8, 2023
711d074
Merge pull request #2304 from nvnieuwk/fix-max_time-template
nvnieuwk Jun 8, 2023
e40580b
Reduce to shortened version of action-tower-launch version
adamrtalbot Jun 8, 2023
d5b7bd2
Add singularity.registry = 'quay.io' to pipeline template
drpatelh Jun 8, 2023
1143084
fix: Parsing of container directive
adamrtalbot Jun 8, 2023
da476f2
CHANGELOG
adamrtalbot Jun 8, 2023
c98848a
Removed 'removeprefix' which is Py > 3.9 only
adamrtalbot Jun 8, 2023
d454093
The repo must not be in detached state for Tower's UI.
MatthiasZepper Jun 8, 2023
58a7d08
Fixing some additional minor bugs
MatthiasZepper Jun 8, 2023
8fe15ea
Use specific Nextflow + nf-amazon version to get check if tests pass
adamrtalbot Jun 8, 2023
d24652a
Use specific Nextflow + nf-amazon version to get check if tests pass
adamrtalbot Jun 8, 2023
130aac7
Introduce latest branch for all Tower downloads, bugix in prompt_sing…
MatthiasZepper Jun 8, 2023
27a18b9
Bugfix in with file validation in prompt_singularity_cachedir_remote(…
MatthiasZepper Jun 8, 2023
9ce5ce4
Adapting the test to the new behavior.
MatthiasZepper Jun 8, 2023
b4f86d5
Update create-test-wf.yml
drpatelh Jun 8, 2023
44a7c7d
Apply suggestions from code review
mirpedrol Jun 9, 2023
51882b2
Revert "Use specific Nextflow + nf-amazon version to get check if tes…
adamrtalbot Jun 9, 2023
7af5f95
do not check if multiqc_config exists
mirpedrol Jun 9, 2023
225864a
@alneberg suggested that lastest should not be enforced if other bran…
MatthiasZepper Jun 9, 2023
446a6e5
Fix regex for containers
adamrtalbot Jun 9, 2023
32fa770
Fix parsing of tags so they should match in most situations
adamrtalbot Jun 9, 2023
90dc179
Match strip strings for consistency
adamrtalbot Jun 9, 2023
b6dbc8b
Revert setting docker_tag and singularity_tag
adamrtalbot Jun 9, 2023
9745652
Better error handling for failed singularity pullcommands.
MatthiasZepper Jun 9, 2023
8abe1a6
Adapt the mechanism to identify the latest version, since distutils m…
MatthiasZepper Jun 9, 2023
56d1a99
Fewer false positives for docker container names
adamrtalbot Jun 9, 2023
1a04dfc
More singularity tag parsing
adamrtalbot Jun 9, 2023
9379ef8
create .nextflow/nf-core if it doesn't exist
mirpedrol Jun 12, 2023
87144bf
Update comment description of check_process_section where it extracts…
adamrtalbot Jun 12, 2023
2c2e2d6
update changelog
mirpedrol Jun 12, 2023
6ef1fa3
Add period to singularity tag parsing
adamrtalbot Jun 12, 2023
1e39535
Merge pull request #2312 from mirpedrol/refgenie-check-path
mirpedrol Jun 12, 2023
5d00842
Add ability to select custom registry when linting modules
adamrtalbot Jun 9, 2023
9b70efb
Quick test update
adamrtalbot Jun 12, 2023
464f0f7
CHANGELOG
adamrtalbot Jun 12, 2023
5e52513
Added 'quay.io' as default for lint_modules
adamrtalbot Jun 12, 2023
4fe8a04
Add test for quay.io and public.aws.ecr explicitly for a direct
adamrtalbot Jun 12, 2023
e571681
add docs to commit new files before pytest
mirpedrol Jun 12, 2023
202ee4e
check for uncommitted changes
mirpedrol Jun 12, 2023
43b1107
Merge pull request #2308 from MatthiasZepper/Issue_2307
MatthiasZepper Jun 12, 2023
b4e8f82
catch InvalidGitRepositoryError
mirpedrol Jun 13, 2023
3c69971
Merge pull request #2300 from mirpedrol/schema-validation-2
mirpedrol Jun 13, 2023
0eb32e3
remove params.tracedir as it doesn't renders properly in tower
maxulysse Jun 13, 2023
6a2adc1
feat (2311): Infer docker.registry value from nextflow.config
adamrtalbot Jun 13, 2023
5d16c04
Update test
adamrtalbot Jun 13, 2023
ed184c2
Merge branch 'dev' into 2311-interpret-docker.registry-automatically
adamrtalbot Jun 13, 2023
4639b68
Merge pull request #2317 from maxulysse/dev
maxulysse Jun 13, 2023
a5f74b4
add hook_url
maxulysse Jun 13, 2023
113acdc
Merge branch 'dev' into notification_megatests
maxulysse Jun 13, 2023
0b374b5
it's a params
maxulysse Jun 13, 2023
49c793c
Merge branch 'dev' into singularity_registry
drpatelh Jun 13, 2023
1d796dc
Update test to remove single quotes
adamrtalbot Jun 14, 2023
56d0c36
better language around help text
adamrtalbot Jun 14, 2023
ffc7564
Merge branch 'dev' into fix_parsing_container_spec
adamrtalbot Jun 14, 2023
7029b62
Merge branch 'dev' into update_action_tower_launch
adamrtalbot Jun 14, 2023
931b4ee
Merge pull request #2301 from adamrtalbot/update_action_tower_launch
adamrtalbot Jun 14, 2023
11dd7db
Merge pull request #2320 from maxulysse/notification_megatests
maxulysse Jun 14, 2023
0ff6719
Merge branch 'dev' into fix_parsing_container_spec
adamrtalbot Jun 14, 2023
263a5d3
don't update modules_json if module is not updated
mirpedrol Jun 14, 2023
84f807a
update changelog
mirpedrol Jun 14, 2023
6c3a218
fix jinja error when parsing awsfultest.yml
mirpedrol Jun 15, 2023
59d2309
Merge pull request #2306 from adamrtalbot/fix_parsing_container_spec
adamrtalbot Jun 15, 2023
f63afd2
Merge branch 'dev' into add_custom_registry_to_nfcore_modules_lint
adamrtalbot Jun 15, 2023
3de58f2
Merge pull request #2313 from adamrtalbot/add_custom_registry_to_nfco…
adamrtalbot Jun 15, 2023
8c96eb4
Merge branch 'dev' into singularity_registry
drpatelh Jun 15, 2023
c91aaa6
Merge branch 'dev' into 2311-interpret-docker.registry-automatically
adamrtalbot Jun 15, 2023
887e83e
Merge pull request #2305 from drpatelh/singularity_registry
drpatelh Jun 15, 2023
0ed7210
Remove unused functioN
adamrtalbot Jun 15, 2023
10f1807
Merge branch 'dev' into 2311-interpret-docker.registry-automatically
adamrtalbot Jun 15, 2023
c96c1d1
Merge pull request #2318 from nf-core/2311-interpret-docker.registry-…
adamrtalbot Jun 15, 2023
37c3d06
Merge pull request #2316 from mirpedrol/test-git-aware
mirpedrol Jun 16, 2023
fbe8155
Merge branch 'dev' into fix-update
mirpedrol Jun 16, 2023
af02d91
Add option to dynamically insert too lcitations into MultiQC report
jfy133 Jun 18, 2023
5f0087f
Apply suggestions from code review
jfy133 Jun 19, 2023
7629d3d
don't pin nf-validation version
mirpedrol Jun 20, 2023
b1e8d07
lint for default values null, empty strings or none
mirpedrol Jun 20, 2023
c10c891
update changelog
mirpedrol Jun 20, 2023
cf15617
Merge pull request #2328 from mirpedrol/lint-schema-null-values
mirpedrol Jun 20, 2023
18aa621
add files to ignore if some parts of the tamplet are skipped
mirpedrol Jun 20, 2023
8a86bbc
add pytest create a pipeline and skip parts
mirpedrol Jun 20, 2023
a32fd94
update CHANGELOG
mirpedrol Jun 20, 2023
56ca280
run prettier on pipeline_template.yml
mirpedrol Jun 20, 2023
f5c4f4e
ignore bug_report.yml linting if pipeline is unbranded
mirpedrol Jun 20, 2023
591ab1e
Merge pull request #2326 from jfy133/template-mqc-citations-methods
jfy133 Jun 21, 2023
ab8ca2e
Merge pull request #2330 from mirpedrol/fix-linting-create-template
drpatelh Jun 21, 2023
91e81fa
Fix #2332
drpatelh Jun 21, 2023
64d43c4
Add in call to getGenomeAttribute
drpatelh Jun 21, 2023
5306952
Add missing brace
drpatelh Jun 21, 2023
99749d5
Set fasta as default in nextflow.config if not using igenomes
drpatelh Jun 21, 2023
9d643c2
Fix spacing with jinja
drpatelh Jun 21, 2023
b68a67c
Fix spacing with jinja
drpatelh Jun 21, 2023
e7bc80c
Fix ECLint
drpatelh Jun 21, 2023
fc240f5
Update CHANGELOG
drpatelh Jun 21, 2023
b223002
Merge pull request #2333 from drpatelh/template
drpatelh Jun 21, 2023
f220b3f
Add CI tests to test running a pipeline whe it's created from a templ…
mirpedrol Jun 21, 2023
2a4c462
avoid writing tabs in template files
mirpedrol Jun 21, 2023
0df0801
add yml files to artifacts for debugging
mirpedrol Jun 21, 2023
ee00670
fix url when generating assets logo
mirpedrol Jun 22, 2023
760e92e
Merge pull request #2331 from mirpedrol/plugin-version
mirpedrol Jun 22, 2023
8187759
Fix #2332
drpatelh Jun 21, 2023
df3fa9b
Add in call to getGenomeAttribute
drpatelh Jun 21, 2023
f7ca4f4
Add missing brace
drpatelh Jun 21, 2023
c046b27
Set fasta as default in nextflow.config if not using igenomes
drpatelh Jun 21, 2023
351e231
Fix spacing with jinja
drpatelh Jun 21, 2023
8f00b2f
Fix spacing with jinja
drpatelh Jun 21, 2023
086176c
Fix ECLint
drpatelh Jun 21, 2023
f1e2363
Update CHANGELOG
drpatelh Jun 21, 2023
cd40c64
don't pin nf-validation version
mirpedrol Jun 20, 2023
0eae064
run with last Nextflow version
mirpedrol Jun 22, 2023
6149430
add linting of pipelines from different templates
mirpedrol Jun 22, 2023
620ff71
Merge branch 'dev' into different-template-tests
mirpedrol Jun 22, 2023
7b757a7
Merge pull request #2337 from mirpedrol/fix-assets-logo
mirpedrol Jun 22, 2023
4f32c07
Merge pull request #2323 from mirpedrol/fix-update
mirpedrol Jun 22, 2023
d93c86d
use prefix without hyphen - should fix nf-core sync
mirpedrol Jun 22, 2023
aa640ea
don't change the prefix, instead run nf-core sync using a template
mirpedrol Jun 22, 2023
a4d690f
only run different templates CI if pipeline-template files are modified
mirpedrol Jun 22, 2023
65c2d53
add quotes to path filter. does it work now?
mirpedrol Jun 22, 2023
f95bc89
remove results folder before linting the pipeline & fix trailing spaces
mirpedrol Jun 22, 2023
a542152
Refactor CLI commands of nf-core download.
MatthiasZepper Jun 13, 2023
ee39770
Enable pulling from multiple container image libraries (registries).
MatthiasZepper Jun 13, 2023
f06772a
Adapt the tests.
MatthiasZepper Jun 13, 2023
9485e22
Fix the CLI test with regard to the revised CLI.
MatthiasZepper Jun 19, 2023
130ce36
Create a ContainerError class with several specific sub-errors.
MatthiasZepper Jun 19, 2023
cdbe6d1
More extensive tests for the Singularity ContainerErrors.
MatthiasZepper Jun 21, 2023
2845e5c
Handle the Singularity exceptions in get_singularity_images().
MatthiasZepper Jun 21, 2023
82df716
Run issort, README and CHANGELOG updates.
MatthiasZepper Jun 22, 2023
af1f127
Merge branch 'dev' into different-template-tests
mirpedrol Jun 22, 2023
7e55edb
run nf-core sync with verbose
mirpedrol Jun 22, 2023
6d715ea
raise sync exception for debugging
mirpedrol Jun 22, 2023
6e836c3
Add a test for the wrapper around singularity_pull_image() in get_si…
MatthiasZepper Jun 22, 2023
2e678e6
Fix the test for get_singularity_images()
MatthiasZepper Jun 22, 2023
0ec077f
fix reading template areas to skip as a string when an array is not p…
mirpedrol Jun 22, 2023
bbad6b3
try fixing trailing spaces
mirpedrol Jun 22, 2023
5951870
try fixing trailing spaces error
mirpedrol Jun 22, 2023
f9641e0
don't fail ignored
mirpedrol Jun 22, 2023
18a76e8
ignore conf/igenomes.config if the pipeline is created without igenomes
mirpedrol Jun 22, 2023
b5eb200
Merge pull request #2334 from mirpedrol/different-template-tests
mirpedrol Jun 26, 2023
9fe1236
Replaced all 'sys.exit(1)' from the code. Hopefully this does not aff…
MatthiasZepper Jun 26, 2023
ee4a09a
Create a custom exception for intended program terminations. This can…
MatthiasZepper Jun 26, 2023
2c93bd8
Custom excepthook broke rich.traceback coloring. Fixed now.
MatthiasZepper Jun 26, 2023
ae53738
Add Apptainer (Singularity) to Gitpod nf-core base image.
MatthiasZepper Jun 27, 2023
9041d93
Some Click versions may pass `container_library` as empty tuple when …
MatthiasZepper Jun 27, 2023
e22a4f7
Merge PR introducting `--container-library` and refactoring CLI comma…
MatthiasZepper Jun 27, 2023
ac6777a
Phil likes indentation 🤓
ewels Jun 29, 2023
df428cb
Merge pull request #2345 from MatthiasZepper/AddApptainerGitpod
ewels Jun 29, 2023
1bf8d1c
Merge branch 'dev' into fix/2208-remove-tracedir
mirpedrol Jun 29, 2023
1d7c39c
Merge pull request #2290 from nf-core/fix/2208-remove-tracedir
mirpedrol Jun 29, 2023
6aa0b08
Split into two functions. This allows to use the DSL2 regexes also f…
MatthiasZepper Jun 28, 2023
13a43eb
bump to 2.9 for release
mirpedrol Jun 29, 2023
766a639
WIP commit, refactoring regexes again, because well...there are also …
MatthiasZepper Jun 29, 2023
c7c19a2
Almost finished refactoring the container detection. Need to test edg…
MatthiasZepper Jun 29, 2023
ccbb131
Hopefully, refactoring of container detection is finished now. Dedupl…
MatthiasZepper Jun 29, 2023
fd3f641
Added a test, but realized that Sarek has yet another edge-case. Clea…
MatthiasZepper Jun 29, 2023
cdf620e
Add mock config for container detection.
MatthiasZepper Jun 29, 2023
e1b7b7c
Merge pull request #2346 from MatthiasZepper/ContainerErrorDifferenti…
mirpedrol Jun 30, 2023
4a3a79d
Apply suggestions from code review - update changelog
mirpedrol Jun 30, 2023
b568357
Merge branch 'dev' into bump-2.9
mirpedrol Jun 30, 2023
f9e0ea7
Merge pull request #2348 from mirpedrol/bump-2.9
mirpedrol Jun 30, 2023
3921f44
Generate new screengrabs with rich-codex
github-actions[bot] Jun 30, 2023
14aac7a
fix download command for rich-codex in the readme
mirpedrol Jun 30, 2023
96dfa18
update download path for nf-core schema validate image
mirpedrol Jun 30, 2023
d338249
Merge pull request #2350 from mirpedrol/readme-images
mirpedrol Jun 30, 2023
f6cf958
Generate new screengrabs with rich-codex
github-actions[bot] Jun 30, 2023
fe83655
rich-codex remove modules repo folder before clone
mirpedrol Jun 30, 2023
185ecf0
Update nextflow.config
maxulysse Jun 30, 2023
9d39716
Update CHANGELOG.md
maxulysse Jun 30, 2023
de0c247
Update CHANGELOG.md
maxulysse Jun 30, 2023
f7545dd
Merge pull request #2351 from mirpedrol/readme-images
mirpedrol Jun 30, 2023
fb4801b
Merge pull request #2352 from nf-core/apptainer
maxulysse Jun 30, 2023
d2b8a45
Add apptainer keyword to the list of false positive matches. Bare min…
MatthiasZepper Jun 30, 2023
b2e906d
Generate new screengrabs with rich-codex
github-actions[bot] Jun 30, 2023
948de3f
Revert "rich-codex remove modules repo folder before clone"
mirpedrol Jun 30, 2023
bb5644f
Merge pull request #2354 from nf-core/revert-2351-readme-images
mirpedrol Jun 30, 2023
4dee2c5
don't clone modules repo again
mirpedrol Jun 30, 2023
e101f14
add timeout when cloning modules repo
mirpedrol Jun 30, 2023
ab8c46e
Merge pull request #2355 from mirpedrol/rich-codex
mirpedrol Jun 30, 2023
6a96cec
Generate new screengrabs with rich-codex
github-actions[bot] Jun 30, 2023
6b06ccc
remove cd modules
mirpedrol Jun 30, 2023
12b758c
Merge pull request #2356 from mirpedrol/rich-codex
mirpedrol Jun 30, 2023
602e858
Generate new screengrabs with rich-codex
github-actions[bot] Jun 30, 2023
efbe400
add hint to use markdown in component channel description
mashehu Jun 30, 2023
b70a034
update changelog
mashehu Jun 30, 2023
7c62700
Update CHANGELOG.md
mashehu Jun 30, 2023
464f2fb
update changelog
mirpedrol Jun 30, 2023
ffd8f64
Merge pull request #2358 from mashehu/add-markdown-to-modules-template
mashehu Jun 30, 2023
d74b909
Merge #2353: Download: Add `apptainer` to the list of false positve c…
MatthiasZepper Jun 30, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,4 +142,3 @@ To get started:
Devcontainer specs:

- [DevContainer config](.devcontainer/devcontainer.json)
- [Dockerfile](.devcontainer/Dockerfile)
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ body:
attributes:
label: System information
description: |
* Nextflow version _(eg. 22.10.1)_
* Nextflow version _(eg. 23.04.0)_
* Hardware _(eg. HPC, Desktop, Cloud)_
* Executor _(eg. slurm, local, awsbatch)_
* OS _(eg. CentOS Linux, macOS, Linux Mint)_
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-lint-wf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
strategy:
matrix:
NXF_VER:
- "22.10.1"
- "23.04.0"
- "latest-everything"
steps:
# Get the repo code
Expand Down
137 changes: 137 additions & 0 deletions .github/workflows/create-test-lint-wf-template.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
name: Create a pipeline from a template and test it
on:
push:
branches:
- dev
paths:
- nf_core/pipeline-template/**
pull_request:
release:
types: [published]

# Cancel if a newer run is started
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
NXF_ANSI_LOG: false

jobs:
RunTestWorkflow:
runs-on: ubuntu-latest
env:
NXF_ANSI_LOG: false
strategy:
matrix:
TEMPLATE:
- "template_skip_all.yml"
- "template_skip_github_badges.yml"
- "template_skip_igenomes.yml"
- "template_skip_ci.yml"
- "template_skip_nf_core_configs.yml"

steps:
- uses: actions/checkout@v3
name: Check out source-code repository

- name: Set up Python 3.8
uses: actions/setup-python@v4
with:
python-version: 3.8

- name: Install python dependencies
run: |
python -m pip install --upgrade pip
pip install .

- name: Install Nextflow
uses: nf-core/setup-nextflow@v1
with:
version: latest-everything

# Install the Prettier linting tools
- uses: actions/setup-node@v3

- name: Install Prettier
run: npm install -g prettier

# Install the editorconfig linting tools
- name: Install editorconfig-checker
run: npm install -g editorconfig-checker

# Create template files
- name: Create template skip all (except github)
run: |
printf "prefix: my-prefix\nskip: ['ci', 'github_badges', 'igenomes', 'nf_core_configs']" > template_skip_all.yml

- name: Create template skip github_badges
run: |
printf "prefix: my-prefix\nskip: github_badges" > template_skip_github_badges.yml

- name: Create template skip igenomes
run: |
printf "prefix: my-prefix\nskip: igenomes" > template_skip_igenomes.yml

- name: Create template skip ci
run: |
printf "prefix: my-prefix\nskip: ci" > template_skip_ci.yml

- name: Create template skip nf_core_configs
run: |
printf "prefix: my-prefix\nskip: nf_core_configs" > template_skip_nf_core_configs.yml

# Create a pipeline from the template
- name: create a pipeline from the template ${{ matrix.TEMPLATE }}
run: |
nf-core --log-file log.txt create -n testpipeline -d "This pipeline is for testing" -a "Testing McTestface" --template-yaml ${{ matrix.TEMPLATE }}

- name: run the pipeline
run: |
nextflow run my-prefix-testpipeline -profile test,docker --outdir ./results

# Remove results folder before linting
- name: remove results folder
run: |
rm -rf ./results

# Try syncing it before we change anything
- name: nf-core sync
run: nf-core --log-file log.txt sync --dir my-prefix-testpipeline/ --template-yaml ${{ matrix.TEMPLATE }}

# Run code style linting
- name: Run Prettier --check
run: prettier --check my-prefix-testpipeline

- name: Run ECLint check
run: editorconfig-checker -exclude README.md $(find my-prefix-testpipeline/.* -type f | grep -v '.git\|.py\|md\|json\|yml\|yaml\|html\|css\|work\|.nextflow\|build\|nf_core.egg-info\|log.txt\|Makefile')

# Remove TODO statements
- name: remove TODO
run: find my-prefix-testpipeline -type f -exec sed -i '/TODO nf-core:/d' {} \;

# Replace zenodo.XXXXXX to pass readme linting
- name: replace zenodo.XXXXXX
run: find my-prefix-testpipeline -type f -exec sed -i 's/zenodo.XXXXXX/zenodo.123456/g' {} \;

# Run nf-core linting
- name: nf-core lint
run: nf-core --log-file log.txt --hide-progress lint --dir my-prefix-testpipeline --fail-warned

# Run bump-version
- name: nf-core bump-version
run: nf-core --log-file log.txt bump-version --dir my-prefix-testpipeline/ 1.1

# Run nf-core linting in release mode
- name: nf-core lint in release mode
run: nf-core --log-file log.txt --hide-progress lint --dir my-prefix-testpipeline --fail-warned --release

- name: Tar files
run: tar -cvf artifact_files.tar log.txt template_skip*.yml

- name: Upload log file artifact
if: ${{ always() }}
uses: actions/upload-artifact@v3
with:
name: nf-core-log-file
path: artifact_files.tar
2 changes: 1 addition & 1 deletion .github/workflows/create-test-wf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
strategy:
matrix:
NXF_VER:
- "22.10.1"
- "23.04.0"
- "latest-everything"
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pytest-frozen-ubuntu-20.04.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ concurrency:
cancel-in-progress: true

jobs:
pytest:
pytest-frozen:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
Expand Down
1 change: 1 addition & 0 deletions .gitpod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ tasks:
python -m pip install -e .
python -m pip install -r requirements-dev.txt
pre-commit install --install-hooks
nextflow self-update
vscode:
extensions: # based on nf-core.nf-core-extensionpack
- codezombiech.gitignore # Language support for .gitignore files
Expand Down
68 changes: 68 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,73 @@
# nf-core/tools: Changelog

# [v2.9 - Chromium Falcon](https://github.com/nf-core/tools/releases/tag/2.9) + [2023-06-29]

mirpedrol marked this conversation as resolved.
Show resolved Hide resolved
### Template

- `params.max_multiqc_email_size` is no longer required ([#2273](https://github.com/nf-core/tools/pull/2273))
- Remove `cleanup = true` from `test_full.config` in pipeline template ([#2279](https://github.com/nf-core/tools/pull/2279))
- Fix usage docs for specifying `params.yaml` ([#2279](https://github.com/nf-core/tools/pull/2279))
- Added stub in modules template ([#2277])(https://github.com/nf-core/tools/pull/2277) [Contributed by @nvnieuwk]
- Move registry definitions out of profile scope ([#2286])(https://github.com/nf-core/tools/pull/2286)
- Remove `aws_tower` profile ([#2287])(https://github.com/nf-core/tools/pull/2287)
- Fixed the Slack report to include the pipeline name ([#2291](https://github.com/nf-core/tools/pull/2291))
- Fix link in the MultiQC report to point to exact version of output docs ([#2298](https://github.com/nf-core/tools/pull/2298))
- Updates seqeralabs/action-tower-launch to v2.0.0 ([#2301](https://github.com/nf-core/tools/pull/2301))
- Remove schema validation from `lib` folder and use Nextflow [nf-validation plugin](https://nextflow-io.github.io/nf-validation/) instead ([#1771](https://github.com/nf-core/tools/pull/1771/))
- Fix parsing of container directive when it is not typical nf-core format ([#2306](https://github.com/nf-core/tools/pull/2306))
- Add ability to specify custom registry for linting modules, defaults to quay.io ([#2313](https://github.com/nf-core/tools/pull/2313))
- Add `singularity.registry = 'quay.io'` in pipeline template ([#2305](https://github.com/nf-core/tools/pull/2305))
- Add `apptainer.registry = 'quay.io'` in pipeline template ([#2352](https://github.com/nf-core/tools/pull/2352))
- Bump minimum required NF version in pipeline template from `22.10.1` -> `23.04.0` ([#2305](https://github.com/nf-core/tools/pull/2305))
- Add ability to interpret `docker.registry` from `nextflow.config` file. If not found defaults to quay.io. ([#2318](https://github.com/nf-core/tools/pull/2318))
- Add functions to dynamically include pipeline tool citations in MultiQC methods description section for better reporting. ([#2326](https://github.com/nf-core/tools/pull/2326))
- Remove `--tracedir` parameter ([#2290](https://github.com/nf-core/tools/pull/2290))
- Incorrect config parameter warnings when customising pipeline template ([#2333](https://github.com/nf-core/tools/pull/2333))
- Use markdown syntax in the description for the meta map channels ([#2358](https://github.com/nf-core/tools/pull/2358))

### Download

- Introduce a `--tower` flag for `nf-core download` to obtain pipelines in an offline format suited for [seqeralabs® Nextflow Tower](https://cloud.tower.nf/) ([#2247](https://github.com/nf-core/tools/pull/2247)).
- Refactored the CLI for `--singularity-cache` in `nf-core download` from a flag to an argument. The prior options were renamed to `amend` (container images are only saved in the `$NXF_SINGULARITY_CACHEDIR`) and `copy` (a copy of the image is saved with the download). `remote` was newly introduced and allows to provide a table of contents of a remote cache via an additional argument `--singularity-cache-index` ([#2247](https://github.com/nf-core/tools/pull/2247)).
- Refactored the CLI parameters related to container images. Although downloading other images than those of the Singularity/Apptainer container system is not supported for the time being, a generic name for the parameters seemed preferable. So the new parameter `--singularity-cache-index` introduced in [#2247](https://github.com/nf-core/tools/pull/2247) has been renamed to `--container-cache-index` prior to release ([#2336](https://github.com/nf-core/tools/pull/2336)).
- To address issue [#2311](https://github.com/nf-core/tools/issues/2311), a new parameter `--container-library` was created allowing to specify the container library (registry) from which container images in OCI format (Docker) should be pulled ([#2336](https://github.com/nf-core/tools/pull/2336)).
- Container detection in configs was improved. This allows for DSL2-like container definitions inside the container parameter value provided to process scopes [#2346](https://github.com/nf-core/tools/pull/2346).
- Add apptainer to the list of false positve container strings ([#2353](https://github.com/nf-core/tools/pull/2353)).

#### Updated CLI parameters

| Old parameter | New parameter |
| --------------------- | ---------------------------------------------- |
| new parameter | `-d` / `--download-configuration` |
| new parameter | `-t` / `--tower` |
| `-c`/ `--container` | `-s` / `--container-system <VALUE>` |
| new parameter | `-l` / `--container-library <VALUE>` |
| `--singularity-cache` | `-u` / `--container-cache-utilisation <VALUE>` |
| new parameter | `-i` / `--container-cache-index <VALUE>` |

_In addition, `-r` / `--revision` has been changed to a parameter that can be provided multiple times so several revisions can be downloaded at once._

### Linting

- Warn if container access is denied ([#2270](https://github.com/nf-core/tools/pull/2270))
- Error if module container specification has quay.io as prefix when it shouldn't have ([#2278])(https://github.com/nf-core/tools/pull/2278/files)
- Detect if container is 'simple name' and try to contact quay.io server by default ([#2281](https://github.com/nf-core/tools/pull/2281))
- Warn about null/None/empty default values in `nextflow_schema.json` ([#3328](https://github.com/nf-core/tools/pull/2328))
- Fix linting when creating a pipeline skipping some parts of the template and add CI test ([#2330](https://github.com/nf-core/tools/pull/2330))

### Modules

- Don't update `modules_json` object if a module is not updated ([#2323](https://github.com/nf-core/tools/pull/2323))

### Subworkflows

### General

- GitPod base image: Always self-update to the latest version of Nextflow. Add [pre-commit](https://pre-commit.com/) dependency.
- GitPod configs: Update Nextflow as an init task, init pre-commit in pipeline config.
- Refgenie: Create `nxf_home/nf-core/refgenie_genomes.config` path if it doesn't exist ([#2312](https://github.com/nf-core/tools/pull/2312))
- Add CI tests to test running a pipeline whe it's created from a template skipping different areas

# [v2.8 - Ruthenium Monkey](https://github.com/nf-core/tools/releases/tag/2.8) - [2023-04-27]

### Template
Expand Down
Loading
Loading