Dev -> Master for v2.9 #2349
Dev -> Master for v2.9 #2349
Conversation
…h only one revision.
… the new ability to download multiple revisions at once. This resulted in loooooooong filenames.
…load. Ultimately, this now means that I also have to implement multiple version downloads for the classic download. Just downloading the first doesn't seem to make sense from a UX perspective.
…link from singularity to apptainer on the system.
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
… to Version 2.9dev.
…n showing it separately.
Fix readme images from rich-codex
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
rich-codex remove modules repo folder before clone
add apptainer.registry
…imum to possibly support a future apptainer.registry notation.
README.md
Outdated
| @@ -1181,7 +1181,7 @@ The `nf-core subworkflows create` command will prompt you with the relevant ques | |||
|
|
|||
| <!-- RICH-CODEX | |||
| working_dir: tmp | |||
| before_command: git clone https://github.com/nf-core/modules.git && cd modules | |||
| before_command: rm -rf ~/.config/nfcore/nf-core/modules && git clone https://github.com/nf-core/modules.git && cd modules | |||
There was a problem hiding this comment.
| before_command: rm -rf ~/.config/nfcore/nf-core/modules && git clone https://github.com/nf-core/modules.git && cd modules | |
| before_command: cd modules |
We don't have to clone the repo again, it should already be there from the modules commands before (instead of cd we could remove the whole before_command and have working_dir: tmp/modules
Revert "rich-codex remove modules repo folder before clone"
don't clone modules repo again
remove cd modules
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Add markdown hint to modules template
…ontainer strings This is needed, should the keyword "apptainer" start to pop up in DSL2 container definitions.
| @@ -3,6 +3,6 @@ | |||
| Shouldn't do much, as everything is under subcommands. | |||
| """ | |||
|
|
|||
| import pkg_resources | |||
| import importlib.metadata as importlib_metadata | |||
There was a problem hiding this comment.
Admittedly, I am newly using pkg_resources in Downloads:
from pkg_resources import parse_version as VersionParser
It is just something I came by when searching for suggestions online how to reliably sort semantic versions correctly. I am open to change that, in case dropping pkg_resources is desired?
There was a problem hiding this comment.
I don't think we need to drop it, but can think about it if there's a better solution :)
There was a problem hiding this comment.
So far, I am just aware that distutils is deprecated, which I had used initially before switching to pkg_resources. So is importlib the new thing to use (at least for tools)?
No description provided.