Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-schema: No such thing as a range type #738

Closed
5 tasks done
mashehu opened this issue Oct 1, 2020 · 2 comments
Closed
5 tasks done

json-schema: No such thing as a range type #738

mashehu opened this issue Oct 1, 2020 · 2 comments
Labels
bug Something isn't working schema

Comments

@mashehu
Copy link
Contributor

mashehu commented Oct 1, 2020

Thanks to @jfy133, I read through the json-schema specs for ranges again and it turns out what we treat as range types are just number types with a minimum/maximum property... 🤯

So we have to fix that in the following files:

  • tools repo:
    • launch.py
    • test_launch.py
  • nf-co.re repo:
    • launch.php
    • pipeline_schema_builder.php
    • nf-core-schema-builder.js
@ewels ewels added bug Something isn't working schema labels Nov 11, 2020
@ewels
Copy link
Member

ewels commented Dec 9, 2020

@mashehu - is this all done now? Can we close this issue?

@mashehu
Copy link
Contributor Author

mashehu commented Dec 10, 2020

Yes, thanks! I forgot to update it once the new tools release was out.

@mashehu mashehu closed this as completed Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working schema
Projects
None yet
Development

No branches or pull requests

2 participants