Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip hyphens from hashtags for mastodon compatibiluty #3176

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Sep 18, 2024

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

could you update the CHANGELOG.md? The bot is failing because we modified the structure, so it's not automated now

@jfy133
Copy link
Member Author

jfy133 commented Sep 18, 2024

Done, I hope that's OK @mirpedrol !

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jfy133
Copy link
Member Author

jfy133 commented Sep 18, 2024

@mirpedrol can I do anything to fix the tests or can I ignore?

@mirpedrol
Copy link
Member

I will have a look! Sorry I didn't notice there were failing tests

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.66%. Comparing base (8e47a33) to head (494a03f).
Report is 4 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol mirpedrol merged commit e113f97 into dev Sep 19, 2024
84 checks passed
@mirpedrol mirpedrol deleted the fix-masto-hashtags branch September 19, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants