Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the DSL2 declaration in the corresponding template files #1535

Closed
2 tasks
JoseEspinosa opened this issue Apr 28, 2022 · 3 comments
Closed
2 tasks
Labels
low-priority template nf-core pipeline/component template

Comments

@JoseEspinosa
Copy link
Member

JoseEspinosa commented Apr 28, 2022

Description of feature

From Nextflow version 22.4.0, the DSL2 declaration is not needed anymore at the top of 4.0 script (i.e. nextflow.enable.dsl = 2). See here. Hence, it can be removed from:

  • the main.nfof the tests files of the module's template
  • the main.nfof the pipeline template (not until the default version of nextflow is bumped to 22.4.0)
@ewels
Copy link
Member

ewels commented May 5, 2022

But it doesn't do any harm, right? I'm not in a rush to remove this as it'll break the pipeline for people running older versions of Nextflow, when they might work otherwise..

@ewels ewels added low-priority template nf-core pipeline/component template labels May 5, 2022
@JoseEspinosa
Copy link
Member Author

Yep, it does no harm, even ask Paolo if it was going to raise any warning and he told me that it was not. Just open the issue to keep track of it in case we want to update the template in the future.

@mirpedrol
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority template nf-core pipeline/component template
Projects
None yet
Development

No branches or pull requests

3 participants