From 4726da5f186c7c577b139c9d9dadf6038d3ea3eb Mon Sep 17 00:00:00 2001 From: "James A. Fellows Yates" Date: Wed, 8 May 2024 21:06:16 +0200 Subject: [PATCH 1/3] Make input validation stricter to ensure run_accessions are unique within each sample --- assets/schema_input.json | 1 + 1 file changed, 1 insertion(+) diff --git a/assets/schema_input.json b/assets/schema_input.json index 6acc00f7..cc335436 100644 --- a/assets/schema_input.json +++ b/assets/schema_input.json @@ -14,6 +14,7 @@ }, "run_accession": { "type": "string", + "unique": ["sample"], "errorMessage": "Run accession must be provided and cannot contain spaces." }, "instrument_platform": { From 5ffcedf6ff36c83b907c43b8b6b6f56c12a0fe52 Mon Sep 17 00:00:00 2001 From: "James A. Fellows Yates" Date: Wed, 8 May 2024 21:08:47 +0200 Subject: [PATCH 2/3] Update CHANGELOG --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b1435a66..15660910 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### `Fixed` +- [#484](https://github.com/nf-core/taxprofiler/pull/484) Improved input validation to immediately fail if run accession IDs within a given sample ID are not unique (❤️ to @sofstam for reporting, fixed by @jfy133) + ### `Dependencies` ### `Deprecated` From 71328f85b2140d6c2f6a2ff04fee51a127844339 Mon Sep 17 00:00:00 2001 From: nf-core-bot Date: Wed, 8 May 2024 19:09:56 +0000 Subject: [PATCH 3/3] [automated] Fix code linting --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 15660910..a2f9d25a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### `Fixed` -- [#484](https://github.com/nf-core/taxprofiler/pull/484) Improved input validation to immediately fail if run accession IDs within a given sample ID are not unique (❤️ to @sofstam for reporting, fixed by @jfy133) +- [#484](https://github.com/nf-core/taxprofiler/pull/484) Improved input validation to immediately fail if run accession IDs within a given sample ID are not unique (❤️ to @sofstam for reporting, fixed by @jfy133) ### `Dependencies`