Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control-FREEC improvements #196
Control-FREEC improvements #196
Changes from 61 commits
8518d36
627019b
10cefaf
6d213a4
8148546
e3453c6
6aa1091
33ff41f
a7b0f00
a3e45c6
d00a8f7
8dfc48a
db4775c
642ddfb
94c82e2
c650e08
424a4f5
8ba3e47
84f039c
b238dd6
83e5348
114e2c0
b76f217
67bc341
9019dc3
6e7262f
9893a3b
05c6e0b
bc6155f
4bdff8e
eb22a0c
5c30fd8
11c3ad3
a722f3e
f4e9883
e71b7bc
70f34d6
d83a244
cb76fef
72d37b7
f202e18
42b19ff
f523aa8
e8c0bf1
bb7aa1f
7b4dda8
9be155c
37573e1
261aa4e
a94696d
0639d72
aae1015
6d2efd0
e03b7a4
20a3556
65a1069
34e9469
b72e27a
0ab51e5
0ae70ed
d1ebfb1
cf620c8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand the idea here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So instead of a useless process here and in the next one, I think we make a new channel that match the ControlFreec process with the input mpileups and make it conditional so we don't even use these two processes at all.
That would be better, and safer, and easier to understand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the output is not with the
.gz
I don't think we're saving it in the results folder actually.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, have to be fixed in the publishDir as I see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no sure why you added that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I could not see the debug messages. Will be restored eventually :)