-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First speed pass #56
Comments
For the homepage you mean: The It can be handy to copy to your job working dir and start editing when you are in a remote machine and do not want to use the |
Brilliant, thanks!
Right, sorry. Yes - whatever gets linting to pass without ignoring.
Who would not want to use such a wonderful thing?! 😭 ok, fair enough, I see how the YAML file is nice to work with 😅 This looks like it should be fairly generic, it's just rendering from the Nextflow schema file, right? What do you think about breaking it out into a subcommand of nf-core/tools? It could be useful for most Nextflow pipelines I think. That would help to keep the pipeline repo clean and also make the tool available to everyone.. The groups seem to be hardcoded, any reason for that? |
A subcommand for nf-core tools would be cool. The groups were hard coded to keep the options limited to the actual pixelator specific flags and thus make the file shorter by not including descriptions and default for all the boilerplate parameters. |
Great! Do you fancy either making a PR to nf-core/tools, or putting the script into a GitHub gist etc. and opening an issue? Ideally we can get this migrated soon and remove it from the pipeline before release.. |
Can maybe do the same thing by ignoring everything that has |
Yes, that makes sense. I'll make a PR. |
You can find the PR here: nf-core/tools#2362 |
Just waiting for |
Right, forgot about that. It is gone now: PixelgenTechnologies@e9cbb60 |
Thanks! |
First couple of quick things from looking over the files, without actually reading the real code...
Please delete these files:
CODEOWNERS
samplesheet.transformed.csv
Minor changes:
CITATIONS.md
(cutadapt, fastp)https://github.com/PixelgenTechnologies/nf-core-pixelator/blob/ccaabedecb40d7817f728473d94a0bfb2a8fde73/nextflow.config#L261
https://github.com/PixelgenTechnologies/nf-core-pixelator/blob/ccaabedecb40d7817f728473d94a0bfb2a8fde73/.nf-core.yml#L5-L7
Questions
The text was updated successfully, but these errors were encountered: