Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on scaling #233

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Add note on scaling #233

merged 4 commits into from
Feb 13, 2024

Conversation

pinin4fjords
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Feb 13, 2024

nf-core lint overall result: Passed ✅

Posted for pipeline commit b38d216

+| ✅ 275 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-13 10:09:23

@WackerO
Copy link
Collaborator

WackerO commented Feb 13, 2024

LGTM! How does shiny scale with such large datasets? If necessary, maybe add a suggestion to turn that off as well?

@pinin4fjords pinin4fjords merged commit c22968c into dev Feb 13, 2024
12 checks passed
@pinin4fjords pinin4fjords deleted the scaling_note branch February 13, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants