Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention missing dots in report volcano #232

Merged
merged 6 commits into from
Feb 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### `Changed`

- [[#232](https://github.com/nf-core/differentialabundance/pull/232)] - Mention missing dots in volcano plot, change rounding, turn off rounding by default ([@WackerO](https://github.com/WackerO), review by [@pinin4fjords](https://github.com/pinin4fjords))

## v1.4.0 - 2023-11-27

### `Added`
Expand Down
15 changes: 8 additions & 7 deletions assets/differentialabundance_report.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -176,12 +176,7 @@ round_dataframe_columns <- function(df, columns = NULL, digits = -1) {
if (is.null(columns)) {
columns <- colnames(df)[(unlist(lapply(df, is.numeric), use.names=F))] # extract only numeric columns for rounding
}

df[,columns] <- round(
data.frame(df[, columns], check.names = FALSE),
digits = digits
)

df[,columns] <- format(data.frame(df[, columns], check.names = FALSE), scientific=T, digits=params$report_round_digits)
# Convert columns back to numeric

for (c in columns) {
Expand Down Expand Up @@ -833,7 +828,6 @@ for (i in 1:nrow(contrasts)){
cat("\n##### ", pvt, " p values\n")
pval_column <- p_value_types[[pvt]]


de_fc <- abs(full_de[[params$differential_fc_column]]) >= log2(params$differential_min_fold_change)
de_fc_label <- paste("abs(logFC) >=", log2(params$differential_min_fold_change))

Expand Down Expand Up @@ -872,6 +866,13 @@ for (i in 1:nrow(contrasts)){

# Let's equalize the axes
max_fc <- max(abs(full_de[[params$differential_fc_column]])) * 1.1

# Print warning if any p values are 0
zero_p <- length(which(full_de[[pval_column]]==0))
if (zero_p) {
cat(paste0("<i>", zero_p, " feature", ifelse(zero_p>1, "s are", " is"), " not shown because of p value = 0; please refer to the results tables.</i><br><br>"))
}

p <- do.call(plotly_scatterplot, plot_args) %>%
layout(xaxis = list(range=list(-max_fc, max_fc)))

Expand Down
1 change: 1 addition & 0 deletions conf/test.config
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,6 @@ params {
gene_sets_files = 'https://github.com/nf-core/test-datasets/modules/data/genomics/mus_musculus/gene_set_analysis/mh.all.v2022.1.Mm.symbols.gmt'

// Report options
report_round_digits = 3
report_contributors = 'Jane Doe\nDirector of Institute of Microbiology\nUniversity of Smallville;John Smith\nPhD student\nInstitute of Microbiology\nUniversity of Smallville'
}
Loading