Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Azure Fusion env misses credentials when no key or SAS provided #5328

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Fix Azure Fusion env misses credentials when no key or SAS provided #5328

merged 2 commits into from
Sep 25, 2024

Conversation

pditommaso
Copy link
Member

@pditommaso pditommaso commented Sep 24, 2024 •
edited
Loading

This PR fixes two issues:

  • Azure Fusion missing authentication if accountKey is provided
  • Catch when service principal exists but no keys or SAS

@pditommaso
Fix Azure Fusion env misses credentials when no key or SAS provided
95ce548 
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@netlify Netlify
Copy link

netlify bot commented Sep 24, 2024 •
edited
Loading

✅ Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit b9adbf5
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/66f326bd29262f0008c4eb12

@pditommaso pditommaso mentioned this pull request Sep 24, 2024
Closed
@pditommaso
test [e2e stage]
b9adbf5 
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso
Copy link
Member Author

Finally all tests are green

@pditommaso pditommaso merged commit e11382c into master Sep 25, 2024
22 checks passed
@pditommaso pditommaso deleted the fix-azure-sas-token branch September 25, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
storage/azure storage/fusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pditommaso @bentsherman