Use devcontainer with php v8.2 and readd preview images to tables #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Mair <c10@posteo.de>
Actually thumbnailUrl gets sent to the api but is dropped. Therefore no preview inside the table is possible anymore. Signed-off-by: Christoph Mair <c10@posteo.de>
MI-KY
changed the title
enjeck
approved these changes
Sep 29, 2024
| @@ -36,6 +36,8 @@ public function parseValue($value, ?Column $column = null): string { | |||
| if($data !== null) { | |||
| if (isset($data['resourceUrl'])) { | |||
| return json_encode(json_encode([ | |||
| 'thumbnailUrl' => $data['thumbnailUrl'], | |||
There was a problem hiding this comment.
I notice that it works for newly created image links, but pre-existing links do not show the previews. But we could handle this in a separate PR
There was a problem hiding this comment.
You're right the change only affects new links because it seems that since this two lines have been missing every link written to the database lacks of a thumbnailUrl (at least in the last versions of tables)... So solving that would maybe need some lookup for links without a thumbnailUrl and then generating / searching the correct one (?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the
devcontainer.jsonto use a container with php v8.2 .Readded
thumbnailUrlandiconso that this data is not dropped anymore when a url to for example an image is saved. I hope this was not intentionally removed by #779 but the result seems to be that actually no preview is shown...Sorry, I wanted to create two PRs but I had some problems because of DCO and I'm not used to this 🙂
Resolves #1392
Resolves #1375