-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Import): expect selectionOptions as array from json #1383
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
We should check with the usergroup column types, too. |
@@ -23,7 +23,7 @@ public function __construct( | |||
private ?int $numberDecimals = null, | |||
private ?string $numberPrefix = null, | |||
private ?string $numberSuffix = null, | |||
private ?string $selectionOptions = null, | |||
private ?array $selectionOptions = null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, are we sure about this? I believe selectionOptions
is a comma-delimited string. Maybe it's only shown as a string in the frontend, idk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from my debugging yes, and the change worked locally.
@blizzz My suggestion for fixing this issue is updating this line https://github.com/nextcloud/tables/blob/main/lib/Controller/ApiTablesController.php#L160 to Otherwise, we have to update the data type in both ColumnController and frontend |
currently an import fails silently (no web UI feedback) with
Argument #15 ($selectionOptions) must be of type ?string, array given
in the logs. This fixes handlig of the selectionOptions.