Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design improvements to date picker #6324

Open
7 of 15 tasks
nimishavijay opened this issue Sep 6, 2024 · 3 comments
Open
7 of 15 tasks

Design improvements to date picker #6324

nimishavijay opened this issue Sep 6, 2024 · 3 comments
Assignees
Labels
2. developing Work in progress design review Issues that were triaged during a design review design Related to design, interface, interaction design, UX, etc. enhancement New feature request

Comments

@nimishavijay
Copy link
Member

nimishavijay commented Sep 6, 2024

Is your feature request related to a problem? Please describe.

Even though there are efforts to migrate to the native date picker, in some cases the NC date picker is used, for eg while booking an appointment we will show the NC date picker all the time.

The visual design of the date picker can be improved such that it reflects the current state of the NC design.

Describe the solution you'd like

Before After
image image

High priority:

  • change the border radius to match the current style
  • Use full month names
  • Make month, year and arrow buttons into tertiary buttons so the focus is on the dates
  • Always use full opacity text and buttons
  • Always use regular font size

Medium priority:

  • Don't show last week of previous month/first week of next month
  • Add margin-bottom: var(--default-grid-baseline) for each row
  • Remove the double arrow buttons in the top row (first and last buttons) as no other date picker uses these buttons

Low priority:

  • remove the 1px border around the entire element
  • There can be a larger gap for every hour as a little divider. In many cases like here, there would then be slots of 4 grouped together to get a better feeling for the time rather than a long list.
  • One of the most important improvements UX-wise is: "disable dates for which no slots are available", is that possible to grey out the dates with no slots?

Date styles:

  • Day names (Su, Mo, etc) are --color-text-maxcontrast
  • Dates are by default --color-main-text
  • class disabled has background-color: var(--color-background-dark);
  • class not-current-month has color: var(--color-text-maxcontrast);

Describe alternatives you've considered

n/a

Additional context

Related to #6322

@nimishavijay nimishavijay added design Related to design, interface, interaction design, UX, etc. enhancement New feature request 0. to triage Pending approval or rejection design review Issues that were triaged during a design review labels Sep 6, 2024
@nimishavijay nimishavijay self-assigned this Sep 6, 2024
@szaimen
Copy link
Contributor

szaimen commented Sep 9, 2024

Hi, shouldnt the NcDateTimePicker finally be migrated over to the NcDateTimePickerNative?

@szaimen szaimen closed this as completed Sep 9, 2024
@szaimen szaimen reopened this Sep 9, 2024
@jancborchardt
Copy link
Member

jancborchardt commented Sep 9, 2024

@szaimen as @nimishavijay said above:

Even though there are efforts to migrate to the native date picker, in some cases the NC date picker is used, for eg while booking an appointment we will show the NC date picker all the time.

Since the datepicker needs to be shown permanently and also indicate on which day there are appointments available, we can not use the native datepicker popup here.
See mockup at #6321 (comment)

@ShGKme
Copy link
Contributor

ShGKme commented Sep 9, 2024

Component is located in https://github.com/nextcloud-libraries/nextcloud-vue/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress design review Issues that were triaged during a design review design Related to design, interface, interaction design, UX, etc. enhancement New feature request
Projects
Status: 🏗️ In progress
Status: 🏗️ At engineering
Development

No branches or pull requests

6 participants