Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign app settings toggle so it looks like Files in Nextcloud 30 #6141

Closed
Tracked by #80
ChristophWurst opened this issue Jul 11, 2024 · 3 comments · Fixed by nextcloud-libraries/nextcloud-vue#5814
Assignees
Labels
3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. enhancement New feature request
Milestone

Comments

@ChristophWurst
Copy link
Member

Is your feature request related to a problem? Please describe.

image
vs
image

Describe the solution you'd like

Make the Calendar one look like Files

  • Shouldn't be highlighted
  • Shouldn't be pill style

Describe alternatives you've considered

No response

Additional context

No response

@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of design Related to design, interface, interaction design, UX, etc. enhancement New feature request labels Jul 11, 2024
@ChristophWurst ChristophWurst added this to the v4.8.0 milestone Jul 11, 2024
@GVodyanov
Copy link
Contributor

Should be fixed by using latest nextcloud vue nextcloud-libraries/nextcloud-vue@8c75d88

Do you confirm @st3iny ?

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Jul 15, 2024

border radius yes but we also have to make it left-aligned. not sure if that is also handled by nc/vue already?

Contacts and Mail have centered text. Calendar is left aligned already 👍

@st3iny
Copy link
Member

st3iny commented Jul 15, 2024

True, but the styling is still a bit off compared to files. It should be a tertiary button but currently looks like a secondary button. Also the padding doesn't seem to be matching. The button on files is slightly more padded and bigger overall.

PS: This might be a problem with the component from nc-vue as we are still using the oldschool expanding menu.

@st3iny st3iny self-assigned this Jul 17, 2024
@st3iny st3iny added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jul 17, 2024
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. enhancement New feature request
Projects
3 participants