Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design issues to fix with the new design #100

Closed
2 of 3 tasks
jancborchardt opened this issue Jul 11, 2024 · 1 comment
Closed
2 of 3 tasks

Design issues to fix with the new design #100

jancborchardt opened this issue Jul 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Jul 11, 2024

Which version of assistant are you using?

2.0.1

Which version of Nextcloud are you using?

30.0.0 dev (daily instance)

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox

Describe the Bug

There are some things to adjust following the design adjustments from nextcloud/server#45751 and nextcloud/server#45657

In Assistant, they seem to be only a few, namely:

  • The input fields are too tall and use the thick border – seems to still use the old input field component?
  • The "New conversation" button seems custom, should be a tertiary button component so the border and radius is consistent
  • The header seems to be too tall, possibly manually set height. Notice that the text with the date is lower than the left navigation toggle

image

Expected Behavior

Design to be adjusted :D

To Reproduce

Open the Assistant on the daily instance.

@jancborchardt jancborchardt added the bug Something isn't working label Jul 11, 2024
@julien-nc
Copy link
Member

The input fields are too tall and use the thick border

This is NcRichContenteditable which still has a thick border in nc/vue 8.14.0.

Shall we wait for a nc/vue update or dirty-patch this in the assistant right now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants