Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove nullish coalescing inside getter #1180

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Sep 11, 2024

Removed a nullish coalescing assignment in a class getter -- which even though is claimed to be supported -- behaved badly in old versions of webkit browsers like Safari 15, some versions of Mobile Safari, and old chromium iOS browsers that use webkit.

Overview

Changed statement in EventBuffer.js class

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-312050

Fixes #1174

Testing

Validated manually using LambdaTest with browser outside of supported table. Ideally, tested using an experiment build and affected customer(s)

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.69 kB / 11.1 kB (gzip) 30.69 kB / 11.1 kB (gzip) 0% / 0.01% (gzip)
lite async-chunk 50.27 kB / 16.33 kB (gzip) 50.28 kB / 16.33 kB (gzip) 0.02% / 0.01% (gzip)
pro loader 51.33 kB / 17.72 kB (gzip) 51.33 kB / 17.72 kB (gzip) 0% / 0.03% (gzip)
pro async-chunk 96.81 kB / 29.3 kB (gzip) 96.82 kB / 29.3 kB (gzip) 0.01% / 0.01% (gzip)
spa loader 58.98 kB / 20.1 kB (gzip) 58.98 kB / 20.1 kB (gzip) 0% / 0% (gzip)
spa async-chunk 111.87 kB / 33.64 kB (gzip) 111.88 kB / 33.65 kB (gzip) 0.01% / 0.01% (gzip)

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (b12131c) to head (76576e2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1180   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files         165      165           
  Lines        7249     7249           
  Branches     1484     1485    +1     
=======================================
  Hits         6412     6412           
  Misses        716      716           
  Partials      121      121           
Flag Coverage Δ
unit-tests 78.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metal-messiah metal-messiah merged commit e537359 into main Sep 16, 2024
21 checks passed
@metal-messiah metal-messiah deleted the optional-chaining-safari-bug branch September 16, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safari 15.1: undefined is not an object (evaluating 'this.held.merge')
2 participants