Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks don't have access to AWS permissions in PR's from forks #343

Open
tathey1 opened this issue Feb 1, 2022 · 3 comments
Open

Checks don't have access to AWS permissions in PR's from forks #343

tathey1 opened this issue Feb 1, 2022 · 3 comments
Labels
no-issue-activity

Comments

@tathey1
Copy link
Member

tathey1 commented Feb 1, 2022 •
edited
Loading

I tested two trivial PR's, one from a fork where I got an AWS error, and one from a branch where there was no error.

Is it possible to allow forks to access AWS keys for checks without compromising security?
This was referenced Feb 1, 2022
Closed
Closed
Merged
@tathey1
Copy link
Member Author

tathey1 commented Feb 11, 2022

modified circleci config so forks only test black formatting and all pytests except those in the utils module. utils pytests, and codecov are only run for branches.

Thus, the checks do not reflect code coverage or utils tests for PR's from forks

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Stale issue message

@tathey1 tathey1 reopened this Feb 13, 2023
@github-actions
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tathey1