Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning 2.0 support #1662

Open
lminer opened this issue Jul 11, 2023 · 3 comments
Open

Lightning 2.0 support #1662

lminer opened this issue Jul 11, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@lminer
Copy link

lminer commented Jul 11, 2023

It would be nice to be able to use pytorch-lightning 2.0. We switch over to lightning 2.0 as soon as torch 2.0 was released, but would love to be able to try sparseml!

@lminer lminer added the enhancement New feature or request label Jul 11, 2023
@bfineran
Copy link
Contributor

Hi @lminer we currently support torch 2.0 installs with sparseml however the new torch.compile feature is not supported as it does not yet support hooks/modifications after compilation which is the core of what we do to sparsify torch models.

As for lighting support, an official integration is not yet on our roadmap, but if you are interested you should likely be able to integrate sparseml into pytorch lightning callbacks

@jeanniefinks
Copy link
Member

Hello @lminer
Some time has passed between our last comment and hearing back. I hope the insight @bfineran has proven helpful. I'd like to go ahead and close out this thread. But if you would like to continue the conversation, please re-open this issue. Thank you so much!
Jeannie / Neural Magic

@lminer
Copy link
Author

lminer commented Jul 26, 2023

Could we leave it open. I'm guessing that at some point in time you'll add support for lightning 2.0, and it would be nice to have this issue as a record of when the change will be made.

@jeanniefinks jeanniefinks reopened this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants